This repository has been archived by the owner on Dec 12, 2018. It is now read-only.
Incompatible request and uuid versions in package.json #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 25, 2017 13:59
Bump the version of request so that we don't try to include node-uuid
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the package.json, you are requiring request 2.74 which depends on a very old/outdated version of uuid (it incorporates it as
require('node-uuid')) and is not compatible with the uuid 3.0.0 that you have listed.The easiest thing (I think) is to bump the request version up to something current (i.e. 2.81.0) and since the APIs are relatively self-contained, I think that this is a pretty low risk change and helps make it work for people (like myself) who are using npm's package-lock versioning.
One related note, I tried to run the tests on the okta branch and they failed (definitely unrelated to the change I'm proposing here). Just thought you might like to know that as well.