Skip to content
This repository has been archived by the owner on Dec 12, 2018. It is now read-only.

Redis URL support #382

Open
lancecarlson opened this issue Feb 5, 2016 · 4 comments
Open

Redis URL support #382

lancecarlson opened this issue Feb 5, 2016 · 4 comments

Comments

@lancecarlson
Copy link

createClient(); can take a url parameter. Would be nice to support it! If I submit a patch to get this working, would you take it?

@robertjd
Copy link
Member

robertjd commented Feb 5, 2016

Hey there! It is possible to pass options down to Redis, please let me know
if this isn't documented well.
On Feb 4, 2016 7:53 PM, "Lance Carlson" [email protected] wrote:

createClient(); can take a url parameter. Would be nice to support it! If
I submit a patch to get this working, would you take it?


Reply to this email directly or view it on GitHub
#382.

@lancecarlson
Copy link
Author

Hmm, how can I go about it? I went around it by creating my own redis client and passing that

@robertjd
Copy link
Member

robertjd commented Feb 5, 2016

Are you looking at these docs?
https://docs.stormpath.com/nodejs/api/client#redis
On Feb 4, 2016 9:28 PM, "Lance Carlson" [email protected] wrote:

Hmm, how can I go about it? I went around it by creating my own redis
client and passing that


Reply to this email directly or view it on GitHub
#382 (comment)
.

@lancecarlson
Copy link
Author

Yes, I see a place to pass host and port, but no place to pass a URL.

Also looking at the code itself, I noticed you were only passing parameters to the redis client using the host/port method and don't allow for passing an object (which will allow you to pass a url parameter instead)

https://github.com/stormpath/stormpath-sdk-node/blob/master/lib/cache/RedisStore.js#L22

Arity for createClient()

https://github.com/NodeRedis/node_redis#rediscreateclient

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants