fix(schema): handle non-string enum values #1377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P0lip
force-pushed
the
fix/non-string-enum-values-ajv-errors
branch
from
bdd54b0
to
53c6950
Compare
P0lip
force-pushed
the
fix/non-string-enum-values-ajv-errors
branch
from
53c6950
to
040ebc8
Compare
philsturgeon
previously approved these changes
Oct 7, 2020
P0lip
added a commit
that referenced
this pull request
Nov 1, 2020
* fix(schema): handle non-string enum values * test: update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted while working on #1353
Right now, if enum contains a null and the value does not match, an exception is thrown.
Also opened a PR to the upstream package atlassian/better-ajv-errors#82
Checklist
Does this PR introduce a breaking change?