Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gauntlet update to reduce hash changes #226

Open
a-frantz opened this issue Oct 17, 2024 · 0 comments
Open

Gauntlet update to reduce hash changes #226

a-frantz opened this issue Oct 17, 2024 · 0 comments

Comments

@a-frantz
Copy link
Member

The current issue: Everytime a gauntlet or arena repo pushes a new commit, we can get hundreds of lines show up in the git diff but none of them we care about. This leads to a situation where diagnostic changes we care about may get lost in the noise. It also means PRs end up with a bunch of git changes that are unrelated to the PR.

The fix: (originally a comment left on #194 that I have now expanded on)
I envision there being two types of changes to Gauntlet.toml/Arena.toml and they won't overlap in the same PR:

  1. diagnostic changes (without hash changes)
    • these changes happen in our "typical" PRs (for lack of a better word)
    • New lint diagnostics, changes in diagnostic language, etc.
    • These are the changes we really care about
  2. hash changes (which may or may not include diagnostic changes)
    • these will happen in dedicated PRs that run maybe once a week?
      • Could be automated, could be manual
    • any diagnostic changes happening here, we will know is because of a change "upstream" and not because of a regression in our code

To facilitate this, gauntlet will need some changes. The "regular" and "arena" run modes will need to stop pulling in new changes. --refresh could be renamed --bless. Then we'd need a new flag (which is mutually exclusive with --refresh/bless) that goes and updates all the commit hashes (probably just call it --update?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant