-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@placeholder no longer a candidate for acc description #62
Comments
@stevefaulkner It's challenging to update this since it requires a patch to both the website and the test files which are in another repository. What to you recommend? Updating the results here and filing a new issue to the TPG repo? As for this repo, the site fix seems to be: mark Safari as passing and mark Edge as failing. But I'd prefer to avoid that political pitfall unless @dstorey gives his blessing on the Edge edit. Otherwise, I'll just mark Safari as passing. |
#72 Updates Safari results |
@jasonkiss @stevefaulkner this was correct but looks like the spec changed after we implemented :( Is placeholder just removed from accDesc or also accName too? (presumably just the former) If the former the fix is either to remove ph-002 and ph-003 tests or to leave them to explicitly test against the previously correct behavior and change the test desc to say placeholder shouldn't be the accDesc. |
Regarding Edge implementation, if this is the new behaviour I'll work with the team to get Edge behaviour updated for an upcoming release. |
Update: Regarding Edge support, we're updating to remove placeholder from the name/description mapping to reflect the latest version of the spec. @stevefaulkner how would you like the test to change? I can spare some cycles to update it if you like. My initial thought is to just remove the name/description requirement in the placeholder test, as it is consistent with the rest of the test where only features that contribute to name/desc algorithm include that test. The test already includes the requirement to map placeholder/aria-placeholder correctly. |
@dstorey yeah if you can update would be great! the change you suggest sounds good. |
Please see PR at ThePacielloGroup/AT-browser-tests#62 |
Update the
placeholder
attribute test page to reflect thatplaceholder
no longer participates in the accessible description computation as outlined in the HTML-AAM.The text was updated successfully, but these errors were encountered: