Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Linting): Remove linting overrides and fix errors #106

Open
nokome opened this issue Nov 26, 2019 · 0 comments
Open

chore(Linting): Remove linting overrides and fix errors #106

nokome opened this issue Nov 26, 2019 · 0 comments
Labels
good first issue Good for newcomers

Comments

@nokome
Copy link
Member

nokome commented Nov 26, 2019

Following a move to eslint (from tslint) some lint errors were changed to warnings to get the build to pass. These overrides should be removed and the lint errors fixed:

dockta/package.json

Lines 104 to 110 in 2f1453d

"rules": {
"@typescript-eslint/prefer-regexp-exec": 1,
"@typescript-eslint/require-await": 1,
"@typescript-eslint/restrict-plus-operands": 1,
"@typescript-eslint/strict-boolean-expressions": 1,
"@typescript-eslint/unbound-method": 1
}

@nokome nokome added the good first issue Good for newcomers label Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant