CAP-0046-06: Fix events emitted #1564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Change the events emitted by Stellar Asset Contracts to match the implementation.
Why
If you look at the code of what events are emitted, they don't currently match the specification, with data values incorrect, as well as parameters.
https://github.com/stellar/rs-soroban-env/blob/v21.2.2/soroban-env-host/src/builtin_contracts/stellar_asset_contract/event.rs#L56-L71
Reviewing
When reviewing, please thoroughly check the changes with the code. This is the second time we're correcting the events in the CAP with the implementation, having already attempted to get it aligned at least one other time since implementation, and these docs should be reliable, so it's worth two people thoroughly confirming.
cc @stellar/contract-committers