Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update limits #996

Merged
merged 5 commits into from
Oct 9, 2024
Merged

Update limits #996

merged 5 commits into from
Oct 9, 2024

Conversation

briwylde08
Copy link
Contributor

No description provided.

@briwylde08 briwylde08 marked this pull request as draft September 24, 2024 15:11
@stellar-jenkins
Copy link

@anupsdf
Copy link
Contributor

anupsdf commented Sep 28, 2024

Core PR for the new limits, stellar/stellar-core#4491

@stellar-jenkins
Copy link

1 similar comment
@stellar-jenkins
Copy link

@briwylde08 briwylde08 marked this pull request as ready for review October 3, 2024 18:26
Copy link
Contributor

@anupsdf anupsdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marked some settings as KiB. The state archival one stays at KB. In future, how about splitting them into transaction level limits and ledger wide limits?

docs/networks/resource-limits-fees.mdx Outdated Show resolved Hide resolved
docs/networks/resource-limits-fees.mdx Outdated Show resolved Hide resolved
docs/networks/resource-limits-fees.mdx Outdated Show resolved Hide resolved
docs/networks/resource-limits-fees.mdx Outdated Show resolved Hide resolved
docs/networks/resource-limits-fees.mdx Outdated Show resolved Hide resolved
@briwylde08
Copy link
Contributor Author

@anupsdf I think that's probably a good idea. We can split them up in a separate PR.

@stellar-jenkins
Copy link

@anupsdf
Copy link
Contributor

anupsdf commented Oct 3, 2024

We probably should merge this PR on October 9th when the new limits go live.

@briwylde08
Copy link
Contributor Author

Sounds good. @ElliotFriend are you okay to merge this on Oct. 9th? I'm out of town next week so hoping to lean on you!

@ElliotFriend ElliotFriend merged commit d15acc4 into main Oct 9, 2024
2 checks passed
@ElliotFriend ElliotFriend deleted the update-limits branch October 9, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants