-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-organizing API documentation collections #169
Conversation
These changes make it a bit more manageable to collect our various API specifications into a single navbar item in our docusaurus site. With the upcoming addition of the Hubble information, this will ease the implementation, and make things a bit more uniform. - I've included some nginx rewrites that I _think_ will do the correct redirections from any old URLs to the new ones. - There is now a single `API` dropdown menu item in the site's navbar, instead of having separate navbar links for all the various APIs, we can now collect them under a single button. - The `DocSidebar` component has been swizzled to allow us to keep the "category" of API used in the breadcrumbs, but to not clutter the sidebar with extra (and unnecessary) links. Signed-off-by: Elliot Voris <[email protected]>
Something went wrong with PR preview build please check |
Good grief that's a lot of files changed!! 290!! 😮 The main changes are these:
|
Signed-off-by: Elliot Voris <[email protected]>
Signed-off-by: Elliot Voris <[email protected]>
Preview is available here: |
got myself into a redirect loop there. Signed-off-by: Elliot Voris <[email protected]>
Signed-off-by: Elliot Voris <[email protected]>
Preview is available here: |
Preview is available here: |
I would recommend "APIs" instead of "API" for the drop-down label, but otherwise LGTM, thanks for taking this on! |
Signed-off-by: Elliot Voris <[email protected]>
@JakeUrban Great idea! Pushed that change now. Thank you! |
Preview is available here: |
This is great and we should merge it! WITH ONE MAJOR CAVEAT!!! We need to ensure all broken links are accounted for via the redirects file Given this affects an entire directory you can probably use a few fancy star Once this is sorted this looks good to merge. Nice work! |
Ah I see c6b3f83 now. So maybe this has already been dealt with? |
@tyvdh Yes, I believe those redirects will handle everything. As a means of testing them, I put together this script. Here's what it does:
The only one that didn't respond as "expected" was the TL;DR - I checked all the redirects in the sitemap. Things redirect as I was expecting 👍🏻 |
MERGE IT BABY!!! |
While working on stellar#169, I noticed the READ_FIRST doc in the api directory shows up on the sitemap. This file is intended just for contributors to better orient themselves with the codebase, and it shouldn't be added to the sitemap.
These changes make it a bit more manageable to collect our various API specifications into a single navbar item in our docusaurus site. With the upcoming addition of the Hubble information (#167), this will ease the implementation, and make things a bit more uniform.
API
dropdown menu item in the site's navbar, instead of having separate navbar links for all the various APIs, we can now collect them under a single button.DocSidebar
component has been swizzled to allow us to keep the "category" of API used in the breadcrumbs, but to not clutter the sidebar with extra (and unnecessary) links.