Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update RPC OpenRPC spec #1063

Closed
wants to merge 1 commit into from

Conversation

aditya1702
Copy link
Contributor

No description provided.

@stellar-jenkins
Copy link

@2opremio
Copy link
Contributor

Really Nice!

@aditya1702 aditya1702 changed the title Update RPC OpenRPC spec [WIP] Update RPC OpenRPC spec Oct 29, 2024
@briwylde08
Copy link
Contributor

Hello! Is this PR still a WIP? Or are we ready to merge? @aditya1702

@ElliotFriend
Copy link
Contributor

Before we merge this!

I just had a chance to look at the changes, and it looks like the auto-generated file is the one that got updated. The build process gets re-run, and these changes will be overwritten when the site gets deployed.

The changes should ideally go into the /openrpc/src/stellar-rpc/* source files

@ElliotFriend
Copy link
Contributor

@aditya1702 if you want to take a crack at moving the changes into that directory, /openrpc/README.md can help with some guidance and tips.

On the other hand, if you want, I can help migrate the changes into those files. I know it's a tricky setup, and I'd hate for you to have to duplicate the work

@aditya1702
Copy link
Contributor Author

Hello! Is this PR still a WIP? Or are we ready to merge? @aditya1702

@briwylde08 Actually we do want these changes to go in. However, we had to revert these changes temporarily in rpc for the current release. So it makes more sense to do them in the next one when they actually go through. I will close this PR for now and create a new one then

@aditya1702 aditya1702 closed this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants