Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp 'Choosing the right storage' article. #1006

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

dmkozh
Copy link
Contributor

@dmkozh dmkozh commented Sep 26, 2024

I just wanted to add some clarification on independence of storage types, but ended up revamping it completely:

  • Remove/update outdated info (such as reference to Wasm being stored in the contract instance)
  • Remove/rephrase/move around less relevant info. The old article had a very long and irrelevant diversion on the role of state archival, that has nothing to do with the purpose of the guide.
  • Add a table that highlights the differences between the storage types
  • Update sections dedicated to individual storage types
  • Rewrite the examples in order to avoid demonstrating anti-patterns (like auth-less storage modificaitons) and demonstrate intricacies of the storage (especially the temp storage)

I still feel like some of the info might be too verbose, but I think this is still a step in the right direction in terms of the information usefulness.

I just wanted to add some clarification on independence of storage types, but ended up revamping it completely:

- Remove/update outdated info (such as reference to Wasm being stored in the contract instance)
- Remove/rephrase/move around less relevant info. The old article had a very long and irrelevant diversion on the role of state archival, that has nothing to do with the purpose of the guide.
- Add a table that highlights the differences between the storage types
- Update sections dedicated to individual storage types
- Rewrite the examples in order to avoid demonstrating anti-patterns (like auth-less storage modificaitons) and demonstrate intricacies of the storage (especially the temp storage)

I still feel like some of the info might be too verbose, but I think this is still a step in the right direction in terms of the information usefulness.
@stellar-jenkins
Copy link

1 similar comment
@stellar-jenkins
Copy link

@stellar-jenkins
Copy link

Copy link
Contributor

@briwylde08 briwylde08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through for editorial! LGTM otherwise!

@dmkozh dmkozh merged commit 318b686 into stellar:main Sep 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants