Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable isFilled on <Notification/> #258

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Conversation

jeesunikim
Copy link

@jeesunikim jeesunikim commented Sep 11, 2024

  • Enable isFilled option on <Notification/> for success, warning, and error

@jeesunikim jeesunikim changed the title add a yellow background for warning variant on Notification add a yellow background for warning variant on <Notification/> Sep 11, 2024
@stellar-jenkins
Copy link

@@ -26,7 +26,7 @@ import { linkPreview } from "@site/src/componentPreview/linkPreview";
import { loaderPreview } from "@site/src/componentPreview/loaderPreview";
import { modalPreview } from "@site/src/componentPreview/modalPreview";
import { navButtonPreview } from "@site/src/componentPreview/navButtonPreview";
import { notificationPreview } from "@site/src/componentPreview/notificationPreview ";
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there was an empty space between the file name and .tsx

@jeesunikim jeesunikim changed the title add a yellow background for warning variant on <Notification/> enable isFilled on <Notification/> Sep 11, 2024
@stellar-jenkins
Copy link

Copy link
Contributor

@quietbits quietbits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jeesunikim jeesunikim merged commit 3608637 into sds-v3 Sep 12, 2024
2 checks passed
@jeesunikim jeesunikim deleted the add-yellow-notifications branch September 12, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants