Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc conversion optimizations/fixes for protocol 21 #1318

Open
dmkozh opened this issue Jan 8, 2024 · 0 comments
Open

Misc conversion optimizations/fixes for protocol 21 #1318

dmkozh opened this issue Jan 8, 2024 · 0 comments

Comments

@dmkozh
Copy link
Contributor

dmkozh commented Jan 8, 2024

This is an issue to track several small issues found and recorded in https://github.com/stellar/rs-soroban-env/pull/1314/files, such as:

  • Symbol::try_from_val has to use only a single conversion function based on length
  • symbol_new_from_slice should use SCSymbol::try_from_bytes instead of duplicating its logic with slight modification
  • map_new_from_linear_memory should use Symbol::try_from_val on the slice instead of doing XDR roundtrip
  • deserialize_from_bytes should use to_host_val directly
@dmkozh dmkozh mentioned this issue Jan 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dmkozh and others