Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a message on top of RPC pages when the RPC URL is not input #1014

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

jeesunikim
Copy link
Contributor

rpc-url.mov

@@ -194,6 +197,10 @@ export const NetworkSelector = () => {
const latestData = getData();

selectNetwork(latestData);

// also update the network setting for endpoints
updateNetwork(latestData);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added this to update its global endpoints network setting so that users would see the change right away vs. refresh the page to see the updated endpoint

@jeesunikim jeesunikim changed the title display an error message when there is no rpc url set Show a message on top of RPC pages when the RPC URL is not input Sep 11, 2024
@stellar-jenkins
Copy link

@stellar-jenkins
Copy link

1 similar comment
@stellar-jenkins
Copy link

@jeesunikim jeesunikim merged commit 2d536e8 into master Sep 12, 2024
3 checks passed
@jeesunikim jeesunikim deleted the display-message-rpc branch September 12, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Show a message on top of RPC pages when the RPC URL is not input
4 participants