-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: consider adding a second app #1
Comments
Hello Tom! |
Hey @stefanoslig, this is a really good project. Are you still interested in creating the PWA features for this project? let me know if you need help with it. I also want to suggest to use ngrx store facades. |
Hello @cristianmartinez. Thank you! Yes It's in my plans to use facades. I uploaded a branch where I refactored the article lib in order to use facades. I have done some other changes too in order to avoid some dependencies between some libs. You can see the corresponding pull request here pr. I will do the same for the other libs in separated branches for each lib. As for the PWA, the major problem right now is that I don't have mobile-friendly css. And also, I don't believe that the PWA should be a different app. Instead, the main app must be a PWA. |
Thank you for your time creating this repo!
I suggest creating a second app for this repo so that the real world example is more true to real life. Please consider that one of the main motivations for using a mono repo is to reuse libraries in other apps, and seeing this in practice, I believe, would help users understand how to use nx in a multi application.
What are your opinions regarding my suggestion?
Thanks in advance
The text was updated successfully, but these errors were encountered: