-
-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add native addon to cinv API #981
Conversation
… input BREAKING CHANGE: out parameter is no longer supported and now cinv function accepts and returns Complex128 data type input
lib/node_modules/@stdlib/math/base/special/cinv/benchmark/c/native/benchmark.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/cinv/docs/types/test.ts
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/cinv/include/stdlib/math/base/special/cinv.h
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/cinv/test/test.native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/cinv/docs/types/test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @steff456!
- We need to add a benchmark.native.js for benchmarking the native addon when calling from JavaScript.
- Need to use stdlib constant in C implementation.
- Need to fix spaces/tabs.
lib/node_modules/@stdlib/math/base/special/cinv/benchmark/benchmark.native.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @steff456!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @steff456!
Part of https://github.com/stdlib-js/todo/issues/1454
Description
This pull request:
Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers