Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add native addon to cinv API #981

Merged
merged 9 commits into from
Jul 21, 2023
Merged

feat: add native addon to cinv API #981

merged 9 commits into from
Jul 21, 2023

Conversation

steff456
Copy link
Contributor

Part of https://github.com/stdlib-js/todo/issues/1454

Description

What is the purpose of this pull request?

This pull request:

  • Removes out keyword
  • Adds support for Complex128 dtype
  • Adds C implementation
  • Adds native addon with benchmark, tests, examples and readme update

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@steff456
remove: remove out parameter and add support for Complex128 data type…
6f86854 
… input

BREAKING CHANGE: out parameter is no longer supported and now cinv
function accepts and returns Complex128 data type input
@steff456
feat: add C implementation and addon to cinv package
abfae48
@steff456 steff456 added Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. labels Mar 22, 2023
@steff456 steff456 requested a review from kgryte March 22, 2023 17:39
@steff456 steff456 self-assigned this Mar 22, 2023
@kgryte kgryte requested a review from Planeshifter May 31, 2023 00:02
kgryte
kgryte requested changes Jul 14, 2023
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @steff456!

  • We need to add a benchmark.native.js for benchmarking the native addon when calling from JavaScript.
  • Need to use stdlib constant in C implementation.
  • Need to fix spaces/tabs.

kgryte
kgryte approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @steff456!

kgryte
kgryte approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @steff456!

@kgryte kgryte merged commit 70a1973 into develop Jul 21, 2023
7 checks passed
@kgryte kgryte deleted the cinv-addon branch July 21, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

@Planeshifter Planeshifter Awaiting requested review from Planeshifter

Assignees

@steff456 steff456

Labels
Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@steff456 @kgryte