Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C ndarray API and refactor blas/ext/base/dnansumors #3001

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

feat: add C ndarray API and refactor blas/ext/base/dnansumors #3001

wants to merge 7 commits into from

Conversation

headlessNode
Copy link
Contributor

Resolves none.

Description

What is the purpose of this pull request?

This pull request:

  • Adds C ndarray API and refactor/cleanup blas/ext/base/dnansumors

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Oct 11, 2024
@kgryte kgryte added Feature Issue or pull request for adding a new feature. C Issue involves or relates to C. labels Oct 11, 2024
@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label Oct 11, 2024
@kgryte
Copy link
Member

kgryte commented Oct 11, 2024

@headlessNode Do you know the reason for the lint failure on CI?

@headlessNode
Copy link
Contributor Author

@kgryte I tried to find it in this PR but didn't find anything in the C files that could be causing this.

@Planeshifter
Copy link
Member

@headlessNode @kgryte To me, it looks like the C lint failures are due to cppcheck installation failing. Could have to do with latest GitHub Actions runner upgrade. Failures are not due to changes in this PR and are occurring in other PRs as well. We may need to look into the compilation failures. Upgrading cppcheck to a newer version could also be explored.

@gunjjoshi gunjjoshi mentioned this pull request Oct 13, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte Awaiting requested review from kgryte

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Needs Changes Pull request which needs changes before being merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@headlessNode @kgryte @Planeshifter @stdlib-bot