-
-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: update scaffolding for creating unary math strided packages #2993
base: develop
Are you sure you want to change the base?
build: update scaffolding for creating unary math strided packages #2993
Conversation
lib/node_modules/@stdlib/_tools/scaffold/math-strided-real-typed-unary/data/README__md.txt
Outdated
Show resolved
Hide resolved
...dules/@stdlib/_tools/scaffold/math-strided-real-typed-unary/data/benchmark/benchmark__js.txt
Outdated
Show resolved
Hide resolved
...tdlib/_tools/scaffold/math-strided-real-typed-unary/data/benchmark/benchmark__native__js.txt
Outdated
Show resolved
Hide resolved
...dlib/_tools/scaffold/math-strided-real-typed-unary/data/benchmark/benchmark__ndarray__js.txt
Outdated
Show resolved
Hide resolved
...ols/scaffold/math-strided-real-typed-unary/data/benchmark/benchmark__ndarray__native__js.txt
Outdated
Show resolved
Hide resolved
...dlib/_tools/scaffold/math-strided-real-typed-unary/data/benchmark/c/benchmark__length__c.txt
Outdated
Show resolved
Hide resolved
@@ -16,6 +16,8 @@ | |||
* limitations under the License. | |||
*/ | |||
|
|||
/* THIS IS A GENERATED FILE. DO NOT EDIT DIRECTLY. */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we are missing suffix support at L30.
...de_modules/@stdlib/_tools/scaffold/math-strided-real-typed-unary/data/examples/index__js.txt
Show resolved
Hide resolved
@@ -16,6 +16,8 @@ | |||
* limitations under the License. | |||
*/ | |||
|
|||
/* THIS IS A GENERATED FILE. DO NOT EDIT DIRECTLY. */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also missing suffix support at L42. I believe we have precedent for this in other scaffolds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't find this in other scaffolds, but should we follow something like this:
{{C_TYPE}} y[] = { {{#if (eq C_TYPE "float")}}0.0f, 0.0f, 0.0f, 0.0f, 0.0f, 0.0f, 0.0f, 0.0f{{else}}0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0{{/if}} };
Description
This pull request:
scaffold.sh
and adds other required files, i.e.,runner.js
,generate_data.js
anddata.json
in_tools/scaffold/math-strided-real-typed-unary
.Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers