Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add WebAssembly configuration for math/base/special/abs2 and math/base/special/sqrt #2989

Merged
merged 2 commits into from
Oct 5, 2024

Conversation

aman-095
Copy link
Member

@aman-095 aman-095 commented Oct 5, 2024

Description

What is the purpose of this pull request?

This pull request adds webassembly configuration for abs2 and sqrt.

Related Issues

Does this pull request have any related issues?

None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Oct 5, 2024
@aman-095 aman-095 added priority: High High priority concern or feature request. and removed Math Issue or pull request specific to math functionality. priority: High High priority concern or feature request. labels Oct 5, 2024
@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Oct 5, 2024
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aman-095 You need to do more than just copy-paste. You also need to set option parameters in other configurations, as well, and you need to add wasm to the list of configuration options.

@kgryte kgryte added the WebAssembly Issue involves or relates to WebAssembly. label Oct 5, 2024
@kgryte kgryte merged commit 2b6f932 into stdlib-js:develop Oct 5, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Math Issue or pull request specific to math functionality. WebAssembly Issue involves or relates to WebAssembly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants