-
-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add fs/read-ndjson
#2969
Open
yaswanthkosuru
wants to merge
3
commits into
stdlib-js:develop
Choose a base branch
from
yaswanthkosuru:fs/readndjson
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: add fs/read-ndjson
#2969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Planeshifter ready for initial review! |
kgryte
added
Feature
Issue or pull request for adding a new feature.
Needs Review
A pull request which needs code review.
Utilities
Issue or pull request concerning general utilities.
labels
Oct 1, 2024
kgryte
reviewed
Oct 1, 2024
kgryte
reviewed
Oct 1, 2024
kgryte
reviewed
Oct 1, 2024
lib/node_modules/@stdlib/_tools/lint/filenames/lib/extensions.json
Outdated
Show resolved
Hide resolved
Should I add these link as ndjson :https://ndjson.org/ in readme. md |
Yes, that would be preferrable. |
@kgryte Ready for final review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature
Issue or pull request for adding a new feature.
Needs Review
A pull request which needs code review.
Utilities
Issue or pull request concerning general utilities.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1074.
Description
his RFC proposes adding a filesystem utility to read a file which is newline-delimited JSON (NDJSON).
Related Issues
#1075
This pull request:
@stdlib/fs/read-ndjson
#1074Checklist
@stdlib-js/reviewers