Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Move Packages in @stdlib/math/base/ops to Respective Subnamespaces #2717

Conversation

yashathwani
Copy link

Description

What is the purpose of this pull request?

This pull request:

  • Moves the packages found in @stdlib/math/base/ops to their respective subnamespaces to improve organization and modularity of the codebase.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our [contributing guidelines][contributing].

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@kgryte
Copy link
Member

kgryte commented Jul 31, 2024

@yashathwani This PR cannot be accepted, as is. There are far too many errors. I suggest first coordinating and communicating with project maintainers before attempting to work on something like this, especially as an early contributor. Performing this migration requires a specific sequence of steps, none of which have been followed here.

@kgryte kgryte closed this Jul 31, 2024
@kgryte kgryte added the Do Not Merge Pull request which should not be merged. label Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Merge Pull request which should not be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: move @stdlib/math/base/ops/* packages to @stdlib/number/* and @stdlib/complex/*
3 participants