Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update INIT Command in the Lib/MakeFile #1957

Closed
wants to merge 1 commit into from

Conversation

xaman27x
Copy link

@xaman27x xaman27x commented Mar 19, 2024

Updated the INIT Command in the Lib/MakeFile directory to include and handle the node-modules which is a crucial part in dependencies.

Resolves # .

Description

What is the purpose of this Pull Request?

This was a previously mentioned issue which is resolved

This pull request:
Ensures that the node modules is properly loaded on request of the INIT command as the pre-requisite to setting up the repository on your machine.

Related Issues

Does this pull request have any related issues?

This pull request:

#/fixes
#/enhances

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

Updated the INIT Command in the Lib/MakeFile directory to include and handle the node-modules which is a crucial part in dependencies.


Signed-off-by: Aman Morghade <[email protected]>
Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@kgryte
Copy link
Member

kgryte commented Mar 19, 2024

Thanks, @xaman27x, for the suggestion. I'm going to reject this PR, however, as it is intentional that dep installation and dev setup are separate steps. I don't want to necessarily install deps when rerunning make init locally and vice versa. We explicitly state in the dev guide the order of steps: https://github.com/stdlib-js/stdlib/blob/7c8d0ced2596cd1ed9e4dec0a40915dd91f59537/docs/development.md#installation.

@kgryte kgryte closed this Mar 19, 2024
@kgryte kgryte added the status: Rejected Proposed change was not accepted. label Mar 19, 2024
@kgryte kgryte reopened this Mar 19, 2024
@kgryte kgryte removed the status: Rejected Proposed change was not accepted. label Mar 19, 2024
@kgryte
Copy link
Member

kgryte commented Mar 19, 2024

No, actually, just checked. init-eslint-plugin already has as a prerequisite: $(NODE_MODULES). Meaning it states that it is dependent on node modules having already been installed. Closing...

@kgryte kgryte closed this Mar 19, 2024
@kgryte kgryte added the status: Rejected Proposed change was not accepted. label Mar 19, 2024
@xaman27x xaman27x deleted the patch-1 branch March 20, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: Rejected Proposed change was not accepted.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants