-
-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add C implementation for math/base/assert/uint32-is-pow2
#1886
Merged
Planeshifter
merged 3 commits into
stdlib-js:develop
from
performant23:feature/add-stdlib/math/base/assert/uint32-is-pow2
Mar 14, 2024
Merged
feat: add C implementation for math/base/assert/uint32-is-pow2
#1886
Planeshifter
merged 3 commits into
stdlib-js:develop
from
performant23:feature/add-stdlib/math/base/assert/uint32-is-pow2
Mar 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit if applied adds the C implementation to @stdlib/math/base/assert/uint32-is-pow2 package
Regarding the naming convention: Since |
Planeshifter
changed the title
feat:
feat: add C implementation for Mar 14, 2024
add C implementation for math/base/assert/uint32-is-pow2
math/base/assert/uint32-is-pow2
Planeshifter
added
Needs Review
A pull request which needs code review.
Math
Issue or pull request specific to math functionality.
Native Addons
Issue involves or relates to Node.js native add-ons.
C
Issue involves or relates to C.
labels
Mar 14, 2024
Pranavchiku
reviewed
Mar 14, 2024
lib/node_modules/@stdlib/math/base/assert/uint32-is-pow2/README.md
Outdated
Show resolved
Hide resolved
Pranavchiku
reviewed
Mar 14, 2024
lib/node_modules/@stdlib/math/base/assert/uint32-is-pow2/README.md
Outdated
Show resolved
Hide resolved
Pranavchiku
reviewed
Mar 14, 2024
lib/node_modules/@stdlib/math/base/assert/uint32-is-pow2/examples/c/example.c
Outdated
Show resolved
Hide resolved
Pranavchiku
reviewed
Mar 14, 2024
lib/node_modules/@stdlib/math/base/assert/uint32-is-pow2/lib/native.js
Outdated
Show resolved
Hide resolved
Pranavchiku
reviewed
Mar 14, 2024
lib/node_modules/@stdlib/math/base/assert/uint32-is-pow2/src/main.c
Outdated
Show resolved
Hide resolved
Signed-off-by: Pranav <[email protected]>
Pranavchiku
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well locally, thanks @performant23 !
Pranavchiku
added
Ready To Merge
A pull request which is ready to be merged.
and removed
Needs Review
A pull request which needs code review.
labels
Mar 14, 2024
lib/node_modules/@stdlib/math/base/assert/uint32-is-pow2/README.md
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/assert/uint32-is-pow2/src/main.c
Outdated
Show resolved
Hide resolved
Signed-off-by: Philipp Burckhardt <[email protected]>
Planeshifter
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C
Issue involves or relates to C.
Math
Issue or pull request specific to math functionality.
Native Addons
Issue involves or relates to Node.js native add-ons.
Ready To Merge
A pull request which is ready to be merged.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit if applied adds the C implementation to
@stdlib/math/base/assert/uint32-is-pow2
packageDescription
This pull request:
@stdlib/math/base/assert/uint32-is-pow2
Related Issues
This pull request:
@stdlib/math/base/assert/uint32-is-pow2
#1868Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers