Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C implementation for math/base/special/boxcox1pinv #1885

Merged
merged 4 commits into from
Mar 14, 2024
Merged

feat: add C implementation for math/base/special/boxcox1pinv #1885

merged 4 commits into from
Mar 14, 2024

Conversation

Rejoan-Sardar
Copy link
Contributor

Description

What is the purpose of this pull request?

This pull request:

  • add C implementation for math/base/special/boxcox1pinv

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

  • Read, understood, and followed the [contributing guidelines][contributing].

@stdlib-js/reviewers

@Planeshifter Planeshifter changed the title feat: add C implementation for math/base/special/boxcox1pinv feat: add C implementation for math/base/special/boxcox1pinv Mar 14, 2024
Pranavchiku
Pranavchiku approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Rejoan-Sardar !

@Pranavchiku Pranavchiku added Feature Issue or pull request for adding a new feature. Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. Ready To Merge A pull request which is ready to be merged. labels Mar 14, 2024
@Planeshifter Planeshifter merged commit 78524df into stdlib-js:develop Mar 14, 2024
7 checks passed
@Rejoan-Sardar Rejoan-Sardar deleted the boxcox1p branch March 15, 2024 02:51
This was referenced Mar 17, 2024
Closed
Closed
@Rejoan-Sardar Rejoan-Sardar mentioned this pull request Apr 1, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pranavchiku Pranavchiku Pranavchiku approved these changes

Assignees
No one assigned
Labels
C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Native Addons Issue involves or relates to Node.js native add-ons. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rejoan-Sardar @Pranavchiku @Planeshifter