Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C implementation for math/base/assert/is-prime #1866

Merged
merged 5 commits into from
Mar 15, 2024
Merged

feat: add C implementation for math/base/assert/is-prime #1866

merged 5 commits into from
Mar 15, 2024

Conversation

aman-095
Copy link
Member

Description

This RFC proposes adding native C implementation for @stdlib/math/base/assert/is-prime

bool stdlib_base_is_prime( const double x )

Related Issues

Does this pull request have any related issues?

None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@kgryte kgryte added Feature Issue or pull request for adding a new feature. Needs Review A pull request which needs code review. Math Issue or pull request specific to math functionality. C Issue involves or relates to C. labels Mar 15, 2024
@stdlib-bot stdlib-bot added Documentation Improvements, additions, or changes to documentation. JavaScript Issue involves or relates to JavaScript. labels Mar 15, 2024
kgryte
kgryte approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @aman-095!

@kgryte kgryte removed Documentation Improvements, additions, or changes to documentation. JavaScript Issue involves or relates to JavaScript. Needs Review A pull request which needs code review. labels Mar 15, 2024
@kgryte kgryte merged commit 39d0327 into stdlib-js:develop Mar 15, 2024
8 checks passed
@aman-095 aman-095 mentioned this pull request Apr 1, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aman-095 @kgryte @stdlib-bot