updated sasumpw #1854
Closed
updated sasumpw #1854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgryte
added
Needs Review
kgryte
reviewed
Mar 14, 2024
lib/node_modules/@stdlib/blas/ext/base/sasumpw/include/stdlib/blas/ext/base/sasumpw.h
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Mar 14, 2024
Comment on lines
+36
to
+45
| STDLIB_NAPI_ARGV(env, info, argv, argc, 3); | ||
| STDLIB_NAPI_ARGV_INT64(env, N, argv, 0); | ||
| STDLIB_NAPI_ARGV_INT64(env, stride, argv, 2); | ||
| STDLIB_NAPI_ARGV_STRIDED_FLOAT32ARRAY(env, X, N, stride, argv, 1); | ||
|
|
||
| napi_value v; | ||
| napi_status status = napi_create_double(env, (double)stdlib_strided_ssumpw(N, (float *)X, stride), &v); | ||
| assert(status == napi_ok); | ||
|
|
||
| return v; |
There was a problem hiding this comment.
We use TABS in C files.
Also, the function call is incorrect. The API is sasumpw, not ssumpw.
kgryte
reviewed
Mar 14, 2024
| @@ -34,7 +34,12 @@ | |||
| "-lm" | |||
| ], | |||
| "libpath": [], | |||
| "dependencies": [] | |||
| "dependencies": [ | |||
There was a problem hiding this comment.
This configuration file needs to be updated to include additional build configurations. See @stdlib/blas/ext/base/dfill for an example.
kgryte
reviewed
Mar 14, 2024
kgryte
requested changes
Mar 14, 2024
There was a problem hiding this comment.
Thanks for working on this @ShivamAhir. I've left some initial comments.
kgryte
added
Needs Changes
…blas/ext/base/sasumpw.h Co-authored-by: Athan <[email protected]> Signed-off-by: Shivam <[email protected]>
…ive.js Co-authored-by: Athan <[email protected]> Signed-off-by: Shivam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves # .
Description
This pull request:
Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers