Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update blas/ext/base/sapxsum to follow current project conventions #1850

Merged
merged 24 commits into from
Mar 21, 2024
Merged

refactor: update blas/ext/base/sapxsum to follow current project conventions #1850

merged 24 commits into from
Mar 21, 2024

Conversation

gunjjoshi
Copy link
Member

Resolves #1510.

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@Planeshifter Planeshifter added Needs Review A pull request which needs code review. Native Addons Issue involves or relates to Node.js native add-ons. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. labels Mar 12, 2024
Pranavchiku
Pranavchiku requested changes Mar 12, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few questions and changes left.

lib/node_modules/@stdlib/blas/ext/base/sapxsum/docs/repl.txt Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/blas/ext/base/sapxsum/docs/repl.txt Show resolved Hide resolved
lib/node_modules/@stdlib/blas/ext/base/sapxsum/lib/index.js Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/blas/ext/base/sapxsum/lib/ndarray.js Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/blas/ext/base/sapxsum/lib/ndarray.native.js Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/blas/ext/base/sapxsum/test/test.ndarray.js Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/blas/ext/base/sapxsum/test/test.ndarray.js Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/blas/ext/base/sapxsum/test/test.ndarray.native.js Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/blas/ext/base/sapxsum/test/test.sapxsum.js Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/blas/ext/base/sapxsum/test/test.sapxsum.native.js Outdated Show resolved Hide resolved
@Pranavchiku Pranavchiku added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 12, 2024
gunjjoshi and others added 15 commits March 13, 2024 07:36
@gunjjoshi @Pranavchiku
Update lib/node_modules/@stdlib/blas/ext/base/sapxsum/lib/index.js
d5aeba3 
Co-authored-by: Pranav <[email protected]>
Signed-off-by: GUNJ JOSHI <[email protected]>
@gunjjoshi @Pranavchiku
Update lib/node_modules/@stdlib/blas/ext/base/sapxsum/test/test.ndarr…
9f6b3e4 
…ay.js

Co-authored-by: Pranav <[email protected]>
Signed-off-by: GUNJ JOSHI <[email protected]>
@gunjjoshi
Update test.sapxsum.native.js
c704c27 
Signed-off-by: GUNJ JOSHI <[email protected]>
@gunjjoshi
Update test.ndarray.js
c34effa 
Signed-off-by: GUNJ JOSHI <[email protected]>
@gunjjoshi
Update test.ndarray.native.js
3f55a99 
Signed-off-by: GUNJ JOSHI <[email protected]>
@gunjjoshi
Update test.sapxsum.js
ac5899a 
Signed-off-by: GUNJ JOSHI <[email protected]>
@gunjjoshi
Update ndarray.js
8d890b2 
Signed-off-by: GUNJ JOSHI <[email protected]>
@gunjjoshi
Update ndarray.native.js
140145a 
Signed-off-by: GUNJ JOSHI <[email protected]>
@gunjjoshi
Update addon.c
8a14b5d 
Signed-off-by: GUNJ JOSHI <[email protected]>
@gunjjoshi
Update test.ndarray.js
82f7cea 
Signed-off-by: GUNJ JOSHI <[email protected]>
@gunjjoshi
Update test.ndarray.native.js
fd38276 
Signed-off-by: GUNJ JOSHI <[email protected]>
@gunjjoshi
Update test.sapxsum.js
84bd77d 
Signed-off-by: GUNJ JOSHI <[email protected]>
@gunjjoshi
Update test.sapxsum.native.js
5d03ac9 
Signed-off-by: GUNJ JOSHI <[email protected]>
@gunjjoshi
Update test.ndarray.native.js
8d12d1d 
Signed-off-by: GUNJ JOSHI <[email protected]>
@gunjjoshi
Update repl.txt
b010fd3 
Signed-off-by: GUNJ JOSHI <[email protected]>
@gunjjoshi
Copy link
Member Author

I have left a small doubt. Rest all changes have been made. Thanks @Pranavchiku !

Pranavchiku
Pranavchiku approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @gunjjoshi !

@Pranavchiku Pranavchiku added Ready To Merge A pull request which is ready to be merged. and removed Needs Changes Pull request which needs changes before being merged. labels Mar 13, 2024
@kgryte kgryte added Enhancement Issue or pull request for enhancing existing functionality. and removed Ready To Merge A pull request which is ready to be merged. labels Mar 14, 2024
@kgryte kgryte self-requested a review March 14, 2024 11:14
kgryte
kgryte requested changes Mar 21, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is missing required changes to the package's manifest.json file.

@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label Mar 21, 2024
kgryte
kgryte approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @gunjjoshi!

@kgryte kgryte merged commit 1c4fd83 into stdlib-js:develop Mar 21, 2024
8 checks passed
@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Mar 21, 2024
@gunjjoshi gunjjoshi deleted the sapxsum branch March 21, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

@Pranavchiku Pranavchiku Pranavchiku approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Enhancement Issue or pull request for enhancing existing functionality. Native Addons Issue involves or relates to Node.js native add-ons.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor blas/ext/base/sapxsum to follow current project conventions
4 participants
@gunjjoshi @kgryte @Pranavchiku @Planeshifter