Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add math/base/special/acotd #1785

Merged
merged 8 commits into from
Mar 12, 2024
Merged

feat: add math/base/special/acotd #1785

merged 8 commits into from
Mar 12, 2024

Conversation

the-r3aper7
Copy link
Contributor

@the-r3aper7 the-r3aper7 commented Mar 8, 2024 •
edited
Loading

Resolves #43

Description

What is the purpose of this pull request?

This pull request:

  • Adds functionality to compute acotd of any given input.
input secd
0 90.0
$\sqrt{3}$ 30
1 45
$\sqrt{3} \div 3$ 60

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves #
  • fixes #

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@Planeshifter Planeshifter changed the title feat: add math/base/special/acotd feat: add math/base/special/acotd Mar 8, 2024
@Planeshifter Planeshifter added Needs Review A pull request which needs code review. Math Issue or pull request specific to math functionality. JavaScript Issue involves or relates to JavaScript. labels Mar 8, 2024
the-r3aper7 and others added 5 commits March 10, 2024 02:01
@the-r3aper7
Update README.md
2809281 
Signed-off-by: Sai Srikar Dumpeti <[email protected]>
@the-r3aper7
Update README.md
927cd27 
Signed-off-by: Sai Srikar Dumpeti <[email protected]>
@the-r3aper7
Update test.js
754e9ac 
Signed-off-by: Sai Srikar Dumpeti <[email protected]>
@the-r3aper7
Update main.js
24654a4 
Signed-off-by: Sai Srikar Dumpeti <[email protected]>
@the-r3aper7
feat: add math/base/special/acotd
9656102
@Planeshifter Planeshifter self-requested a review March 12, 2024 13:42
@Planeshifter
Update Julia REQUIREs
e8d3a91 
Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter
Apply suggestions from code review
cf00231 
Signed-off-by: Philipp Burckhardt <[email protected]>
Planeshifter
Planeshifter approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's get acotd in.

@Planeshifter Planeshifter merged commit 7489261 into stdlib-js:develop Mar 12, 2024
7 checks passed
@the-r3aper7 the-r3aper7 deleted the acotd branch March 12, 2024 14:00
@the-r3aper7 the-r3aper7 mentioned this pull request Mar 15, 2024
Closed
5 tasks
@Rejoan-Sardar Rejoan-Sardar mentioned this pull request Mar 17, 2024
Closed
1 task
@Planeshifter Planeshifter removed the Needs Review A pull request which needs code review. label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
JavaScript Issue involves or relates to JavaScript. Math Issue or pull request specific to math functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement acotd
2 participants
@the-r3aper7 @Planeshifter