Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add string/base/last-code-point #1755

Merged
merged 10 commits into from
Mar 13, 2024
Merged

feat: add string/base/last-code-point #1755

merged 10 commits into from
Mar 13, 2024

Conversation

adityacodes30
Copy link
Contributor

@adityacodes30 adityacodes30 commented Mar 7, 2024 •
edited
Loading

Resolves #1702

Description

What is the purpose of this pull request?

This PR adds the package @stdlib/string/base/last-code-point

This pull request:

  • Adds the package @stdlib/string/base/last-code-point which returns the last n Unicode code points of a string.

Related Issues

Does this pull request have any related issues?

#854

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@Planeshifter Planeshifter added Needs Review A pull request which needs code review. JavaScript Issue involves or relates to JavaScript. labels Mar 7, 2024
Pranavchiku
Pranavchiku requested changes Mar 8, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes, thanks for your contribution, @adityacodes30 !

lib/node_modules/@stdlib/string/base/last-code-point/README.md Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/string/base/last-code-point/README.md Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/string/base/last-code-point/docs/types/index.d.ts Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/string/base/last-code-point/docs/types/index.d.ts Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/string/base/last-code-point/docs/types/index.d.ts Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/string/base/last-code-point/examples/index.js Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/string/base/last-code-point/lib/main.js Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/string/base/last-code-point/lib/main.js Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/string/base/last-code-point/lib/main.js Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/string/base/last-code-point/lib/main.js Show resolved Hide resolved
@Pranavchiku Pranavchiku added Feature Issue or pull request for adding a new feature. Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 8, 2024
@Pranavchiku Pranavchiku added Needs Review A pull request which needs code review. and removed Needs Changes Pull request which needs changes before being merged. labels Mar 10, 2024
@adityacodes30
Copy link
Contributor Author

changes have been made , this PR is ready for review

@Planeshifter
Apply suggestions from code review
8512bd8 
Signed-off-by: Philipp Burckhardt <[email protected]>
Planeshifter
Planeshifter approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the edits! Did another review pass and believe this is ready to be merged. 🚀

@Planeshifter Planeshifter added Ready To Merge A pull request which is ready to be merged. and removed Needs Review A pull request which needs code review. labels Mar 13, 2024
@Planeshifter Planeshifter merged commit 7bce237 into stdlib-js:develop Mar 13, 2024
7 checks passed
@adityacodes30 adityacodes30 mentioned this pull request Mar 25, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

@Pranavchiku Pranavchiku Awaiting requested review from Pranavchiku

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature. JavaScript Issue involves or relates to JavaScript. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: add @stdlib/string/base/last-code-point
3 participants
@adityacodes30 @Planeshifter @Pranavchiku