-
-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add napi/argv-complex128
#1745
feat: add napi/argv-complex128
#1745
Conversation
Something happened with the previous PR. So I closed that and created a new one. |
napi/argv-complex128
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR requires many of the same changes discussed in #1760.
@kgryte Can you please review it :) |
…/Ut-the-pro/1745
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I refactored to ensure consistent error handling with other argv-*
utilities. This is now ready for merge.
Resolves #816 .
Description
This pull request adds C APIs for converting a JavaScript
Complex128
object instance to a native C data typestdlib_complex128_t
.Related Issues
This pull request:
@stdlib/napi/argv-complex128
#816Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers