Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add napi/argv-complex128 #1745

Merged
merged 16 commits into from
Apr 17, 2024
Merged

feat: add napi/argv-complex128 #1745

merged 16 commits into from
Apr 17, 2024

Conversation

utkrs01
Copy link
Contributor

@utkrs01 utkrs01 commented Mar 7, 2024

Resolves #816 .

Description

What is the purpose of this pull request?

This pull request adds C APIs for converting a JavaScript Complex128 object instance to a native C data type stdlib_complex128_t.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@utkrs01
Copy link
Contributor Author

utkrs01 commented Mar 7, 2024

Something happened with the previous PR. So I closed that and created a new one.

@Planeshifter Planeshifter changed the title feat: add napi/argv-complex128 feat: add napi/argv-complex128 Mar 8, 2024
@kgryte kgryte added Feature Issue or pull request for adding a new feature. Needs Review A pull request which needs code review. Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. labels Mar 17, 2024
kgryte
kgryte requested changes Mar 17, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR requires many of the same changes discussed in #1760.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 17, 2024
@utkrs01 utkrs01 requested a review from kgryte March 18, 2024 06:48
@utkrs01
Copy link
Contributor Author

utkrs01 commented Apr 13, 2024

@kgryte Can you please review it :)

@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Apr 17, 2024
kgryte
kgryte approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I refactored to ensure consistent error handling with other argv-* utilities. This is now ready for merge.

@kgryte kgryte merged commit ced016b into stdlib-js:develop Apr 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Native Addons Issue involves or relates to Node.js native add-ons.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: Add @stdlib/napi/argv-complex128
2 participants
@utkrs01 @kgryte