Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update blas/ext/base/ssumors to follow current project conventions #1692

Merged
merged 6 commits into from
Mar 5, 2024
Merged

refactor: update blas/ext/base/ssumors to follow current project conventions #1692

merged 6 commits into from
Mar 5, 2024

Conversation

lovelindhoni
Copy link
Contributor

Resolves #1543 .

Description

This pull request refactors blas/ext/base/ssumors to follow current project conventions.

Related Issues

Related issues #788 , #1152

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@kgryte kgryte added Enhancement Issue or pull request for enhancing existing functionality. Native Addons Issue involves or relates to Node.js native add-ons. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. labels Mar 4, 2024
kgryte
kgryte requested changes Mar 4, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, @lovelindhoni. If you can update the indentation of manifest.json, I think this PR should be ready for merge.

@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label Mar 4, 2024
@Planeshifter Planeshifter added Ready To Merge A pull request which is ready to be merged. and removed Needs Changes Pull request which needs changes before being merged. labels Mar 5, 2024
@Planeshifter
Copy link
Member

Let's get this in once CI passes; thanks for your contribution, @lovelindhoni!

@Planeshifter Planeshifter merged commit ef026dc into stdlib-js:develop Mar 5, 2024
7 checks passed
@lovelindhoni
Copy link
Contributor Author

Apologies @Planeshifter, I was going to fix my silly indentation issue. Thanks for sparing your time.

utkrs01 pushed a commit to utkrs01/stdlib that referenced this pull request Mar 7, 2024
@lovelindhoni @kgryte @Planeshifter
refactor: update blas/ext/base/ssumors to follow current project co…
05ef806 
…nventions

PR-URL: stdlib-js#1692
Closes: stdlib-js#1543

---------

Signed-off-by: Athan Reines <[email protected]>
Signed-off-by: Lovelin <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Co-authored-by: Athan Reines <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
@kgryte kgryte removed the Ready To Merge A pull request which is ready to be merged. label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte requested changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Enhancement Issue or pull request for enhancing existing functionality. Native Addons Issue involves or relates to Node.js native add-ons.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor blas/ext/base/ssumors to follow current project conventions
3 participants
@lovelindhoni @Planeshifter @kgryte