Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C implementation for constants/int32/max #1683

Merged
merged 2 commits into from
Mar 4, 2024
Merged

feat: add C implementation for constants/int32/max #1683

merged 2 commits into from
Mar 4, 2024

Conversation

Pranavchiku
Copy link
Member

@Pranavchiku Pranavchiku commented Mar 4, 2024 •
edited
Loading

Description

What is the purpose of this pull request?

This pull request adds C implementation for @stdlib/constants/int32/max

Related Issues

Does this pull request have any related issues?

Removes blocker for gcd, requested by @aman-095.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@Pranavchiku Pranavchiku added the C Issue involves or relates to C. label Mar 4, 2024
@Pranavchiku
Copy link
Member Author

Can I put a ready to merge for my PR? XD

@kgryte kgryte added Feature Issue or pull request for adding a new feature. Utilities Issue or pull request concerning general utilities. labels Mar 4, 2024
kgryte
kgryte approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @Pranavchiku.

@kgryte kgryte merged commit 869def2 into stdlib-js:develop Mar 4, 2024
6 checks passed
utkrs01 pushed a commit to utkrs01/stdlib that referenced this pull request Mar 7, 2024
@Pranavchiku @kgryte
feat: add C implementation for constants/int32/max
3a0c7dd 
PR-URL: 	stdlib-js#1683
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Signed-off-by: Athan Reines <[email protected]>
@performant23
Copy link
Contributor

Hi, just noticed that the C macros are not there for float16 and some integer and unsigned integer constants in @stdlib/constants. Would these be needed for any present/future C implementations? If so, happy to write some macros!

@kgryte
Copy link
Member

kgryte commented Mar 22, 2024

@performant23 I think the most high priority constants would be for float32. See https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/constants/float32/half-pi for an example. Feel free to submit PRs for constants which seem most relevant from float64 (e.g., apery, catalan, etc, are not high priority).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Utilities Issue or pull request concerning general utilities.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pranavchiku @performant23 @kgryte