-
-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add C implementation for constants/int32/max
#1683
Conversation
Can I put a ready to merge for my PR? XD |
lib/node_modules/@stdlib/constants/int32/max/include/stdlib/constants/int32/max.h
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/constants/int32/max/include/stdlib/constants/int32/max.h
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @Pranavchiku.
PR-URL: stdlib-js#1683 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]> Signed-off-by: Athan Reines <[email protected]>
Hi, just noticed that the C macros are not there for |
@performant23 I think the most high priority constants would be for |
Description
This pull request adds C implementation for
@stdlib/constants/int32/max
Related Issues
Removes blocker for
gcd
, requested by @aman-095.Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers