Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update blas/ext/base/ssumpw to follow current project conventions #1673

Merged
merged 8 commits into from
Mar 4, 2024
Merged

refactor: update blas/ext/base/ssumpw to follow current project conventions #1673

merged 8 commits into from
Mar 4, 2024

Conversation

lovelindhoni
Copy link
Contributor

Resolves #1544 .

Description

This pull request refactors blas/ext/base/ssumpw to follow current project conventions.

Related Issues

Related issues #788 , #1152 .

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@lovelindhoni lovelindhoni changed the title refactor: update blas/ext/base/ssumpw to follow current project conve… refactor: update blas/ext/base/ssumpw to follow current project conventions Mar 3, 2024
@kgryte kgryte added Enhancement Issue or pull request for enhancing existing functionality. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Native Addons Issue involves or relates to Node.js native add-ons. labels Mar 3, 2024
kgryte
kgryte requested changes Mar 3, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, @lovelindhoni. Would you mind going back over this PR and using consistent styling? Thanks!

@lovelindhoni lovelindhoni requested a review from kgryte March 4, 2024 02:32
kgryte
kgryte requested changes Mar 4, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lovelindhoni Thanks for the updates. As is, the implementation currently has a bug. Namely, the addon does not return the sum. See, e.g., @stdlib/blas/base/sasum for an example: https://github.com/stdlib-js/stdlib/blob/develop/lib/node_modules/%40stdlib/blas/base/sasum/src/addon.c

@lovelindhoni lovelindhoni requested a review from kgryte March 4, 2024 09:22
kgryte
kgryte approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @lovelindhoni!

@kgryte kgryte merged commit 412acd6 into stdlib-js:develop Mar 4, 2024
7 checks passed
utkrs01 pushed a commit to utkrs01/stdlib that referenced this pull request Mar 7, 2024
@lovelindhoni @kgryte
refactor: update blas/ext/base/ssumpw to follow current project con…
1267ce6 
…ventions

Closes: stdlib-js#1544
PR-URL: 	stdlib-js#1673
Ref: stdlib-js#788
Ref: stdlib-js#1152
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Signed-off-by: Athan Reines <[email protected]>
Signed-off-by: Lovelin <[email protected]>
@kgryte kgryte added the C Issue involves or relates to C. label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Enhancement Issue or pull request for enhancing existing functionality. Native Addons Issue involves or relates to Node.js native add-ons.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor blas/ext/base/ssumpw to follow current project conventions
2 participants
@lovelindhoni @kgryte