-
-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: update blas/ext/base/ssumpw
to follow current project conventions
#1673
Conversation
blas/ext/base/ssumpw
to follow current project conve…blas/ext/base/ssumpw
to follow current project conventions
lib/node_modules/@stdlib/blas/ext/base/ssumpw/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/ssumpw/benchmark/benchmark.native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/ssumpw/benchmark/benchmark.native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/ssumpw/benchmark/benchmark.ndarray.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/ssumpw/benchmark/benchmark.ndarray.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/ssumpw/benchmark/benchmark.ndarray.native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/ssumpw/benchmark/benchmark.ndarray.native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/ssumpw/examples/index.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this, @lovelindhoni. Would you mind going back over this PR and using consistent styling? Thanks!
Signed-off-by: Athan <[email protected]>
lib/node_modules/@stdlib/blas/ext/base/ssumpw/examples/index.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/ssumpw/lib/ndarray.native.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lovelindhoni Thanks for the updates. As is, the implementation currently has a bug. Namely, the addon does not return the sum. See, e.g., @stdlib/blas/base/sasum
for an example: https://github.com/stdlib-js/stdlib/blob/develop/lib/node_modules/%40stdlib/blas/base/sasum/src/addon.c
Signed-off-by: Lovelin <[email protected]>
Signed-off-by: Athan <[email protected]>
Signed-off-by: Athan <[email protected]>
Signed-off-by: Athan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @lovelindhoni!
…ventions Closes: stdlib-js#1544 PR-URL: stdlib-js#1673 Ref: stdlib-js#788 Ref: stdlib-js#1152 Co-authored-by: Athan Reines <[email protected]> Reviewed-by: Athan Reines <[email protected]> Signed-off-by: Athan Reines <[email protected]> Signed-off-by: Lovelin <[email protected]>
Resolves #1544 .
Description
This pull request refactors
blas/ext/base/ssumpw
to follow current project conventions.Related Issues
Related issues #788 , #1152 .
This pull request:
blas/ext/base/ssumpw
to follow current project conventions #1544Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers