Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix manifest.json indentation for some complex APIs #1063

Merged
merged 3 commits into from
Jul 20, 2023
Merged

Conversation

steff456
Copy link
Contributor

Part of https://github.com/stdlib-js/todo/issues/1648

Description

What is the purpose of this pull request?

  • Fixes the indentation of some manifest.json files for the complex APIs

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@steff456 steff456 requested a review from kgryte July 20, 2023 19:55
@steff456 steff456 self-assigned this Jul 20, 2023
@steff456 steff456 changed the title Fix manifest.json indentation Fix manifest.json indentation for some complex APIs Jul 20, 2023
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @steff456! Can you ensure that the manifest.json files have a trailing newline per EditorConfig settings?

@steff456
Copy link
Contributor Author

Sure!!

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @steff456!

@kgryte kgryte merged commit a1d78a7 into develop Jul 20, 2023
5 checks passed
@kgryte kgryte deleted the fix-manifest branch July 20, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants