Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC]: Add @stdlib/random/strided/laplace #1011

Closed
wants to merge 6 commits into from
Closed

[RFC]: Add @stdlib/random/strided/laplace #1011

wants to merge 6 commits into from

Conversation

ShivangRawat30
Copy link

@ShivangRawat30 ShivangRawat30 commented May 17, 2023 •
edited by Planeshifter
Loading

Fixes #940

Resolves # .

Description

What is the purpose of this pull request?

This pull request:

  • a
  • b
  • c

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves #
  • fixes #

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@Planeshifter Planeshifter self-requested a review May 23, 2023 21:39
Planeshifter
Planeshifter requested changes May 23, 2023
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is currently missing the ndarray.js file for the package, causing tests to fail.

@Planeshifter Planeshifter changed the title [RFC]: Add @stdlib/random/array/laplace [RFC]: Add @stdlib/random/strided/laplace May 23, 2023
@Planeshifter Planeshifter mentioned this pull request May 23, 2023
Closed
1 task
kgryte
kgryte requested changes Dec 3, 2023
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs considerable work and contains files from @stdlib/random/base/laplace which should not be present.

As this PR has been dormant for some time, will close.

@kgryte kgryte closed this Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter requested changes

@kgryte kgryte kgryte requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: Add @stdlib/random/strided/laplace
3 participants
@ShivangRawat30 @Planeshifter @kgryte