-
-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add native addon to roundn and croundn #1009
Conversation
…oundn API BREAKING CHANGE: out keyword is no longer supported and now the API uses Complex128 dtype as input and output
lib/node_modules/@stdlib/math/base/special/croundn/examples/index.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/croundn/manifest.json
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/croundn/test/test.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/croundn/test/test.native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/roundn/include/stdlib/math/base/special/roundn.h
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/roundn/manifest.json
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/roundn/test/test.native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/roundn/test/test.native.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @steff456. Mainly just need to update descriptions and address some small comments.
lib/node_modules/@stdlib/math/base/special/croundn/lib/native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/croundn/lib/native.js
Outdated
Show resolved
Hide resolved
Coverage Report
The above coverage report was generated for the changes in this PR. |
Coverage Report
The above coverage report was generated for the changes in this PR. |
Coverage Report
The above coverage report was generated for the changes in this PR. |
Coverage Report
The above coverage report was generated for the changes in this PR. |
Coverage Report
The above coverage report was generated for the changes in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @steff456!
Coverage Report
The above coverage report was generated for the changes in this PR. |
Coverage Report
The above coverage report was generated for the changes in this PR. |
lib/node_modules/@stdlib/math/base/special/croundn/docs/types/index.d.ts
Outdated
Show resolved
Hide resolved
Coverage Report
The above coverage report was generated for the changes in this PR. |
Part of https://github.com/stdlib-js/todo/issues/1454
Description
This pull request:
For roundn API:
For croundn API:
Related Issues
This pull request:
Part of https://github.com/stdlib-js/todo/issues/1454
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers