Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add native addon to cphase API #1004

Merged
merged 5 commits into from
Jul 14, 2023
Merged

feat: add native addon to cphase API #1004

merged 5 commits into from
Jul 14, 2023

Conversation

steff456
Copy link
Contributor

Part of https://github.com/stdlib-js/todo/issues/1454

Description

What is the purpose of this pull request?

This pull request:

  • Adds support for Complex128 dtype
  • Adds C implementation
  • Adds native addon with benchmark, tests, examples and readme update

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@steff456
feat: add support for Complex128 dtype and add native addon to cphase…
b568f8a 
… API

BREAKING CHANGE: now the cphase API receives a double-precision complex
floating-point number instead of a complex comprised by a real and
imaginary component
@steff456
style: fix indentation in manifest.json file
de3c019
@steff456 steff456 added Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. labels Apr 21, 2023
@steff456 steff456 self-assigned this Apr 21, 2023
kgryte
kgryte requested changes Jul 7, 2023
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Left a few comments.

kgryte
kgryte approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @steff456!

@kgryte kgryte merged commit 291afa4 into develop Jul 14, 2023
8 checks passed
@kgryte kgryte deleted the cphase-addon branch July 14, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

@Planeshifter Planeshifter Awaiting requested review from Planeshifter

Assignees

@steff456 steff456

Labels
Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@steff456 @kgryte