Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC]: add C implementation for math/base/special/fast/* (Tracking Issue) #1917

Closed
14 tasks done
gunjjoshi opened this issue Mar 16, 2024 · 9 comments
Closed
14 tasks done

[RFC]: add C implementation for math/base/special/fast/* (Tracking Issue) #1917

gunjjoshi opened this issue Mar 16, 2024 · 9 comments
Labels
Accepted RFC feature request which has been accepted. C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. priority: Normal Normal priority concern or feature request. RFC Request for comments. Feature requests and proposed changes. Tracking Issue Tracking issue.

Comments

@gunjjoshi
Copy link
Member

gunjjoshi commented Mar 16, 2024 •
edited
Loading

Description

This RFC proposes adding C implementations for the following packages :

Related Issues

Related issues #649.

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@gunjjoshi
Copy link
Member Author

gunjjoshi commented Mar 16, 2024 •
edited by kgryte
Loading

This is a tracking issue for C implementations of math/base/special/fast packages.

This was referenced Mar 16, 2024
Merged
Merged
Merged
@Rejoan-Sardar Rejoan-Sardar mentioned this issue Mar 16, 2024
Merged
1 task
@gunjjoshi gunjjoshi changed the title [RFC]: add C implementation for math/base/special/fast/* ( Tracking Issue ) [RFC]: add C implementation for math/base/special/fast/* (Tracking Issue) Mar 16, 2024
@gunjjoshi gunjjoshi mentioned this issue Mar 16, 2024
Merged
@kgryte kgryte added RFC Request for comments. Feature requests and proposed changes. Math Issue or pull request specific to math functionality. Accepted RFC feature request which has been accepted. Tracking Issue Tracking issue. C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. priority: Normal Normal priority concern or feature request. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. labels Mar 17, 2024
@Pranavchiku
Copy link
Member

Pranavchiku commented Mar 17, 2024 •
edited
Loading

Awesome, thanks @gunjjoshi! I'll expect this to get done quickly.

Edit: If there are no blockers for alpha-max-plus-beta-min, uint32-log2,uint32-sqrt please feel free to open PRs and wrap this up.

@gunjjoshi
Copy link
Member Author

Sure @Pranavchiku,, as there are no blockers on the remaining ones, I'll look forward to wrap this up super quick !

@Rejoan-Sardar Rejoan-Sardar mentioned this issue Mar 17, 2024
Closed
3 tasks
@Pranavchiku
Copy link
Member

I think this was close by mistake, reopening

@Pranavchiku Pranavchiku reopened this Mar 18, 2024
@USERSATOSHI
Copy link
Contributor

USERSATOSHI commented Mar 18, 2024 •
edited
Loading

@gunjjoshi Hi,
can you add feat(math): c implementation of alpha-max-plus-beta-min to the track list

for copying the link directly
[feat(math): c implementation of alpha-max-plus-beta-min](https://github.com/stdlib-js/stdlib/pull/1947)

@gunjjoshi
Copy link
Member Author

Done @USERSATOSHI ! Thanks.

@USERSATOSHI
Copy link
Contributor

Done @USERSATOSHI ! Thanks.

I also found this pr for feat: add C implementation for math/base/special/fast/uint32-log2

for copying the link format
[feat: add C implementation for math/base/special/fast/uint32-log2](https://github.com/stdlib-js/stdlib/pull/1946)

@gunjjoshi
Copy link
Member Author

As all tasks are completed, we can close this now.

@Pranavchiku
Copy link
Member

Brilliant, nice job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted RFC feature request which has been accepted. C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. priority: Normal Normal priority concern or feature request. RFC Request for comments. Feature requests and proposed changes. Tracking Issue Tracking issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kgryte @gunjjoshi @USERSATOSHI @Pranavchiku