Auto-generated commit

CHANGELOG.md

@@ -62,10 +62,11 @@
 
 ### Contributors
 
-A total of 4 people contributed to this release. Thank you to the following contributors:
+A total of 5 people contributed to this release. Thank you to the following contributors:
 
 -   Aman Bhansali
 -   Athan Reines
+-   HarshaNP
 -   Philipp Burckhardt
 -   yaswanth
 
@@ -79,6 +80,7 @@ A total of 4 people contributed to this release. Thank you to the following cont
 
 <details>
 
+-   [`7cc8bb9`](https://github.com/stdlib-js/stdlib/commit/7cc8bb9a96147bb94fe8cfddc180a6ec535fc368) - **refactor:** update `blas/ext/base/dsnannsumors` _(by HarshaNP, Philipp Burckhardt)_
 -   [`e9f4e07`](https://github.com/stdlib-js/stdlib/commit/e9f4e0759a14b8da93d4e0837b886d8ed56bc696) - **refactor:** update `blas/ext/base/dsnansumpw` to follow current conventions _(by yaswanth, Philipp Burckhardt)_
 -   [`e0cef99`](https://github.com/stdlib-js/stdlib/commit/e0cef995e884021db3001dc1a3cfef0ca7b368c2) - **style:** remove extra spaces for regular expressions in publish script _(by Philipp Burckhardt)_
 -   [`da12183`](https://github.com/stdlib-js/stdlib/commit/da121832eca80c36e1e32929e994fef44ca8a4cc) - **feat:** add `blas/base/dspr` [(#2794)](https://github.com/stdlib-js/stdlib/pull/2794) _(by Aman Bhansali, Athan Reines)_

ext/base/dsnannsumors/README.md

@@ -59,18 +59,16 @@ The function has the following parameters:
 -   **out**: output [`Float64Array`][@stdlib/array/float64] whose first element is the sum and whose second element is the number of non-NaN elements.
 -   **strideOut**: index increment for `out`.
 
-The `N` and `stride` parameters determine which elements are accessed at runtime. For example, to compute the sum of every other element in `x`,
+The `N` and stride parameters determine which elements are accessed at runtime. For example, to compute the sum of every other element in `x`,
 
 ```javascript
 var Float32Array = require( '@stdlib/array/float32' );
 var Float64Array = require( '@stdlib/array/float64' );
-var floor = require( '@stdlib/math/base/special/floor' );
 
 var x = new Float32Array( [ 1.0, 2.0, NaN, -7.0, NaN, 3.0, 4.0, 2.0 ] );
 var out = new Float64Array( 2 );
-var N = floor( x.length / 2 );
 
-var v = dsnannsumors( N, x, 2, out, 1 );
+var v = dsnannsumors( 4, x, 2, out, 1 );
 // returns <Float64Array>[ 5.0, 2 ]
 ```
 
@@ -81,17 +79,14 @@ Note that indexing is relative to the first index. To introduce an offset, use [
 ```javascript
 var Float32Array = require( '@stdlib/array/float32' );
 var Float64Array = require( '@stdlib/array/float64' );
-var floor = require( '@stdlib/math/base/special/floor' );
 
 var x0 = new Float32Array( [ 2.0, 1.0, NaN, -2.0, -2.0, 2.0, 3.0, 4.0 ] );
 var x1 = new Float32Array( x0.buffer, x0.BYTES_PER_ELEMENT*1 ); // start at 2nd element
 
 var out0 = new Float64Array( 4 );
 var out1 = new Float64Array( out0.buffer, out0.BYTES_PER_ELEMENT*2 ); // start at 3rd element
 
-var N = floor( x0.length / 2 );
-
-var v = dsnannsumors( N, x1, 2, out1, 1 );
+var v = dsnannsumors( 4, x1, 2, out1, 1 );
 // returns <Float64Array>[ 5.0, 4 ]
 ```
 
@@ -120,13 +115,11 @@ While [`typed array`][mdn-typed-array] views mandate a view offset based on the
 ```javascript
 var Float32Array = require( '@stdlib/array/float32' );
 var Float64Array = require( '@stdlib/array/float64' );
-var floor = require( '@stdlib/math/base/special/floor' );
 
 var x = new Float32Array( [ 2.0, 1.0, NaN, -2.0, -2.0, 2.0, 3.0, 4.0 ] );
 var out = new Float64Array( 4 );
-var N = floor( x.length / 2 );
 
-var v = dsnannsumors.ndarray( N, x, 2, 1, out, 2, 1 );
+var v = dsnannsumors.ndarray( 4, x, 2, 1, out, 2, 1 );
 // returns <Float64Array>[ 0.0, 5.0, 0.0, 4 ]
 ```
 
@@ -152,23 +145,23 @@ var v = dsnannsumors.ndarray( N, x, 2, 1, out, 2, 1 );
 <!-- eslint no-undef: "error" -->
 
 ```javascript
-var randu = require( '@stdlib/random/base/randu' );
-var round = require( '@stdlib/math/base/special/round' );
+var discreteUniform = require( '@stdlib/random/base/discrete-uniform' );
+var bernoulli = require( '@stdlib/random/base/bernoulli' );
+var filledarrayBy = require( '@stdlib/array/filled-by' );
 var Float32Array = require( '@stdlib/array/float32' );
 var Float64Array = require( '@stdlib/array/float64' );
 var dsnannsumors = require( '@stdlib/blas/ext/base/dsnannsumors' );
 
 var x;
-var i;
-
-x = new Float32Array( 10 );
-for ( i = 0; i < x.length; i++ ) {
-    if ( randu() < 0.2 ) {
-        x[ i ] = NaN;
-    } else {
-        x[ i ] = round( randu()*100.0 );
+
+function rand() {
+    if ( bernoulli( 0.5 ) < 0.2 ) {
+        return NaN;
     }
+    return discreteUniform( 0, 100 );
 }
+
+x = filledarrayBy( 10, 'float32', rand );
 console.log( x );
 
 var out = new Float64Array( 2 );

ext/base/dsnannsumors/benchmark/benchmark.js

@@ -21,10 +21,11 @@
 // MODULES //
 
 var bench = require( '@stdlib/bench' );
-var randu = require( '@stdlib/random/base/randu' );
+var uniform = require( '@stdlib/random/base/uniform' );
+var bernoulli = require( '@stdlib/random/base/bernoulli' );
+var filledarrayBy = require( '@stdlib/array/filled-by' );
 var isnan = require( '@stdlib/math/base/assert/is-nan' );
 var pow = require( '@stdlib/math/base/special/pow' );
-var Float32Array = require( '@stdlib/array/float32' );
 var Float64Array = require( '@stdlib/array/float64' );
 var pkg = require( './../package.json' ).name;
 var dsnannsumors = require( './../lib/dsnannsumors.js' );
@@ -42,19 +43,18 @@ var dsnannsumors = require( './../lib/dsnannsumors.js' );
 function createBenchmark( len ) {
 	var out;
 	var x;
-	var i;
 
-	x = new Float32Array( len );
-	for ( i = 0; i < len; i++ ) {
-		if ( randu() < 0.2 ) {
-			x[ i ] = NaN;
-		} else {
-			x[ i ] = ( randu()*10.0 ) - 20.0;
-		}
-	}
+	x = filledarrayBy( len, 'float32', rand );
 	out = new Float64Array( 2 );
 	return benchmark;
 
+	function rand() {
+		if ( bernoulli( 0.5 ) < 0.2 ) {
+			return NaN;
+		}
+		return uniform( -10.0, 10.0 );
+	}
+
 	function benchmark( b ) {
 		var i;
 

ext/base/dsnannsumors/benchmark/benchmark.native.js

@@ -22,10 +22,11 @@
 
 var resolve = require( 'path' ).resolve;
 var bench = require( '@stdlib/bench' );
-var randu = require( '@stdlib/random/base/randu' );
+var uniform = require( '@stdlib/random/base/uniform' );
+var bernoulli = require( '@stdlib/random/base/bernoulli' );
+var filledarrayBy = require( '@stdlib/array/filled-by' );
 var isnan = require( '@stdlib/math/base/assert/is-nan' );
 var pow = require( '@stdlib/math/base/special/pow' );
-var Float32Array = require( '@stdlib/array/float32' );
 var Float64Array = require( '@stdlib/array/float64' );
 var tryRequire = require( '@stdlib/utils/try-require' );
 var pkg = require( './../package.json' ).name;
@@ -51,19 +52,18 @@ var opts = {
 function createBenchmark( len ) {
 	var out;
 	var x;
-	var i;
 
-	x = new Float32Array( len );
-	for ( i = 0; i < len; i++ ) {
-		if ( randu() < 0.2 ) {
-			x[ i ] = NaN;
-		} else {
-			x[ i ] = ( randu()*10.0 ) - 20.0;
-		}
-	}
+	x = filledarrayBy( len, 'float32', rand );
 	out = new Float64Array( 2 );
 	return benchmark;
 
+	function rand() {
+		if ( bernoulli( 0.5 ) < 0.2 ) {
+			return NaN;
+		}
+		return uniform( -10.0, 10.0 );
+	}
+
 	function benchmark( b ) {
 		var i;
 

ext/base/dsnannsumors/benchmark/benchmark.ndarray.js

@@ -21,10 +21,11 @@
 // MODULES //
 
 var bench = require( '@stdlib/bench' );
-var randu = require( '@stdlib/random/base/randu' );
+var uniform = require( '@stdlib/random/base/uniform' );
+var bernoulli = require( '@stdlib/random/base/bernoulli' );
+var filledarrayBy = require( '@stdlib/array/filled-by' );
 var isnan = require( '@stdlib/math/base/assert/is-nan' );
 var pow = require( '@stdlib/math/base/special/pow' );
-var Float32Array = require( '@stdlib/array/float32' );
 var Float64Array = require( '@stdlib/array/float64' );
 var pkg = require( './../package.json' ).name;
 var dsnannsumors = require( './../lib/ndarray.js' );
@@ -42,19 +43,18 @@ var dsnannsumors = require( './../lib/ndarray.js' );
 function createBenchmark( len ) {
 	var out;
 	var x;
-	var i;
 
-	x = new Float32Array( len );
-	for ( i = 0; i < len; i++ ) {
-		if ( randu() < 0.2 ) {
-			x[ i ] = NaN;
-		} else {
-			x[ i ] = ( randu()*10.0 ) - 20.0;
-		}
-	}
+	x = filledarrayBy( len, 'float32', rand );
 	out = new Float64Array( 2 );
 	return benchmark;
 
+	function rand() {
+		if ( bernoulli( 0.5 ) < 0.2 ) {
+			return NaN;
+		}
+		return uniform( -10.0, 10.0 );
+	}
+
 	function benchmark( b ) {
 		var i;
 

ext/base/dsnannsumors/benchmark/benchmark.ndarray.native.js

@@ -22,10 +22,11 @@
 
 var resolve = require( 'path' ).resolve;
 var bench = require( '@stdlib/bench' );
-var randu = require( '@stdlib/random/base/randu' );
+var uniform = require( '@stdlib/random/base/uniform' );
+var bernoulli = require( '@stdlib/random/base/bernoulli' );
+var filledarrayBy = require( '@stdlib/array/filled-by' );
 var isnan = require( '@stdlib/math/base/assert/is-nan' );
 var pow = require( '@stdlib/math/base/special/pow' );
-var Float32Array = require( '@stdlib/array/float32' );
 var Float64Array = require( '@stdlib/array/float64' );
 var tryRequire = require( '@stdlib/utils/try-require' );
 var pkg = require( './../package.json' ).name;
@@ -51,19 +52,18 @@ var opts = {
 function createBenchmark( len ) {
 	var out;
 	var x;
-	var i;
 
-	x = new Float32Array( len );
-	for ( i = 0; i < len; i++ ) {
-		if ( randu() < 0.2 ) {
-			x[ i ] = NaN;
-		} else {
-			x[ i ] = ( randu()*10.0 ) - 20.0;
-		}
-	}
+	x = filledarrayBy( len, 'float32', rand );
 	out = new Float64Array( 2 );
 	return benchmark;
 
+	function rand() {
+		if ( bernoulli( 0.5 ) < 0.2 ) {
+			return NaN;
+		}
+		return uniform( -10.0, 10.0 );
+	}
+
 	function benchmark( b ) {
 		var i;
 

ext/base/dsnannsumors/docs/repl.txt

@@ -4,7 +4,7 @@
     ignoring `NaN` values, using ordinary recursive summation with extended
     accumulation, and returning an extended precision result.
 
-    The `N` and `stride` parameters determine which elements are accessed at
+    The `N` and stride parameters determine which elements are accessed at
     runtime.
 
     Indexing is relative to the first index. To introduce an offset, use a typed
@@ -43,11 +43,10 @@
     > {{alias}}( x.length, x, 1, out, 1 )
     <Float64Array>[ 1.0, 3 ]
 
-    // Using `N` and `stride` parameters:
+    // Using `N` and stride parameters:
     > x = new {{alias:@stdlib/array/float32}}( [ -2.0, 1.0, 1.0, -5.0, 2.0, -1.0, NaN, NaN ] );
     > out = new {{alias:@stdlib/array/float64}}( 2 );
-    > var N = {{alias:@stdlib/math/base/special/floor}}( x.length / 2 );
-    > {{alias}}( N, x, 2, out, 1 )
+    > {{alias}}( 4, x, 2, out, 1 )
     <Float64Array>[ 1.0, 3 ]
 
     // Using view offsets:
@@ -58,13 +57,14 @@
     > {{alias}}( N, x1, 2, out, 1 )
     <Float64Array>[ 1.0, 3 ]
 
+
 {{alias}}.ndarray( N, x, strideX, offsetX, out, strideOut, offsetOut )
     Computes the sum of single-precision floating-point strided array elements,
     ignoring `NaN` values and using ordinary recursive summation with extended
     accumulation and alternative indexing semantics.
 
     While typed array views mandate a view offset based on the underlying
-    buffer, the `offset` parameter supports indexing semantics based on a
+    buffer, the offset parameter supports indexing semantics based on a
     starting index.
 
     Parameters
@@ -106,9 +106,8 @@
 
     // Using offset parameter:
     > var x = new {{alias:@stdlib/array/float32}}( [ 1.0, -2.0, 3.0, 2.0, 5.0, 1.0, NaN, NaN ] );
-    > var N = {{alias:@stdlib/math/base/special/floor}}( x.length / 2 );
     > out = new {{alias:@stdlib/array/float64}}( 2 );
-    > {{alias}}.ndarray( N, x, 2, 1, out, 1, 0 )
+    > {{alias}}.ndarray( 4, x, 2, 1, out, 1, 0 )
     <Float64Array>[ 1.0, 3 ]
 
     See Also

ext/base/dsnannsumors/examples/index.js

@@ -18,24 +18,23 @@
 
 'use strict';
 
-var randu = require( '@stdlib/random/base/randu' );
-var round = require( '@stdlib/math/base/special/round' );
-var Float32Array = require( '@stdlib/array/float32' );
+var discreteUniform = require( '@stdlib/random/base/discrete-uniform' );
+var bernoulli = require( '@stdlib/random/base/bernoulli' );
+var filledarrayBy = require( '@stdlib/array/filled-by' );
 var Float64Array = require( '@stdlib/array/float64' );
 var dsnannsumors = require( './../lib' );
 
 var out;
 var x;
-var i;
 
-x = new Float32Array( 10 );
-for ( i = 0; i < x.length; i++ ) {
-	if ( randu() < 0.2 ) {
-		x[ i ] = NaN;
-	} else {
-		x[ i ] = round( randu()*100.0 );
+function rand() {
+	if ( bernoulli( 0.5 ) < 0.2 ) {
+		return NaN;
 	}
+	return discreteUniform( 0, 100 );
 }
+
+x = filledarrayBy( 10, 'float32', rand );
 console.log( x );
 
 out = new Float64Array( 2 );

ext/base/dsnannsumors/include.gypi

@@ -36,7 +36,7 @@
 
     # Source files:
     'src_files': [
-      '<(src_dir)/addon.cpp',
+      '<(src_dir)/addon.c',
       '<!@(node -e "var arr = require(\'@stdlib/utils/library-manifest\')(\'./manifest.json\',{},{\'basedir\':process.cwd(),\'paths\':\'posix\'}).src; for ( var i = 0; i < arr.length; i++ ) { console.log( arr[ i ] ); }")',
     ],
 

ext/base/dsnannsumors/lib/index.js

@@ -31,21 +31,18 @@
 * var x = new Float32Array( [ 1.0, -2.0, NaN, 2.0 ] );
 * var out = new Float64Array( 2 );
 *
-* var v = dsnannsumors( x.length, x, 1, out, 1 );
+* var v = dsnannsumors( 4, x, 1, out, 1 );
 * // returns <Float64Array>[ 1.0, 3 ]
 *
 * @example
 * var Float32Array = require( '@stdlib/array/float32' );
 * var Float64Array = require( '@stdlib/array/float64' );
-* var floor = require( '@stdlib/math/base/special/floor' );
 * var dsnannsumors = require( '@stdlib/blas/ext/base/dsnannsumors' );
 *
 * var x = new Float32Array( [ 2.0, 1.0, 2.0, -2.0, -2.0, 2.0, 3.0, 4.0, NaN, NaN ] );
 * var out = new Float64Array( 2 );
 *
-* var N = floor( x.length / 2 );
-*
-* var v = dsnannsumors.ndarray( N, x, 2, 1, out, 1, 0 );
+* var v = dsnannsumors.ndarray( 5, x, 2, 1, out, 1, 0 );
 * // returns <Float64Array>[ 5.0, 4 ]
 */