Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect valid pathnames before checking whether a path exists (fixes #45) #52

Closed
wants to merge 1 commit into from

Conversation

batterseapower
Copy link

The easiest fix for #45 is just to catch the ValueError, but this is a more comprehensive solution that should handle the general case where a string is supplied that is not also a valid path name.

@coveralls
Copy link

coveralls commented Sep 2, 2017

Coverage Status

Coverage decreased (-4.5%) to 31.061% when pulling 0a3830a on batterseapower:master into a18c171 on stchris:master.

@stchris
Copy link
Owner

stchris commented Jul 1, 2022

I'm hoping to fix this in #87 by separating the file lookup logic in the input auto-detection of the parse function.

@stchris stchris closed this Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants