Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update poison #292

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update poison #292

wants to merge 1 commit into from

Conversation

MasashiYokota
Copy link

Thank you for this awesome project.
As I found that the poison version was still v3.1.0, I've updated poison v4.0.1 which is the latest version.

I would appreciate it very much if you could point out anything to me.

@MasashiYokota
Copy link
Author

MasashiYokota commented Nov 26, 2019 •
edited
Loading

@stavro
I am afraid that you are having a hectic week, but I found that my PR's CI failed caused by the CI's poison version mismatch. (I've checked that mix compile and mix test passed in my environment.)

I'd like to resolve this issue, but I couldn't find any semaphoreci's configuration fiies (eg. .semaphore/semaphore.yml etc.)
Do you have any ideas to resolve it? I look forward to hearing from you.
Thank you.

@MasashiYokota
Copy link
Author

@stavro
I'm terribly sorry to disturb you again, but I'd like you to confirm my PR.

@achempion achempion mentioned this pull request Feb 23, 2020
Merged
@williamweckl
Copy link

Any news on this? I think elixir version needs to be updated at CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stavro stavro Awaiting requested review from stavro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MasashiYokota @williamweckl