Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit screen allows changing of reference build (it should not) #46

Open
MatthewMaher opened this issue Feb 22, 2024 · 1 comment
Open
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@MatthewMaher
Copy link

On the main view page for a study, there is an 'Edit' button that allows the user/creator to edit the Label, Study Name, PMID, etc.

It also allows the user to edit the build (GRCh37 vs GRCh38). This edit should not be allowed since the reference build was used during initial upload/ingestion to assign RSIDs and genenames. But no such reprocessing is done when changing the value on the Edit page. This results in the Build label on the top of the Manhattan plot being inconsistent with the RSIDs and gene names shown below.

@abought
Copy link
Member

abought commented Feb 22, 2024

Good catch. For whatever dev is reading this in the future: this is an edge case, and makes sense to fix.

Someone could edit the field, then click "re-run ingest step".... but those actions are not automatically linked, which is confusing.

Options include:

  1. Making the file rerun ingest when specific metadata fields are changed (might require additional UI to tell user "this is a destructive action")
  2. or: Don't make gwas build editable.

There had been vague plans to make more fields editable, such as plot options (in case someone selected the wrong columns and wanted to re-ingest without re-uploading). This got sidelined for various reasons (including "we added UI to preview parser before upload"), so option 2 is probably the most pragmatic/consistent.

@abought abought added enhancement New feature or request help wanted Extra attention is needed labels Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants