Code review, suggestions, ideas or feedback about my code

[msurdi]

Hi!,

I'm just learning about XState and I'm really liking it so far. I've created a side project and would love any feedback regarding my use of XState on it. Would you do anything differently? How can I make it better? Am I doing things in an idiomatic way?

Sorry on beforehand if this doesn't belong here.

Thanks!

[ChrisShank]

With a quick glance everything looks really clean, but I'm not too familiar with the problem domain you are trying to model! Maybe to throw the question back at you, is there anything that you dont like or think could be improved? 🙃

[github0013]

https://xstate.js.org/docs/guides/states.html#state-methods-and-properties

Just out of curiosity, but state.children seems to be a Map object when I console.log(service). And how does state.children.encoding (encoding should be the invoke id name) still works on a Map object?

x = new Map([["encoding", "abc"]])
// => Map(1) {"encoding" => "abc"}
x.encoding
// => undefined

[ChrisShank]

This is a subtle discrepancy with xstate that is a little confusing (hopefully its resolved in the next breaking change):

state.children // regular object

service.children // Map

[github0013]

oh.. service and state..

And I think I found the explanation in the doc.
https://xstate.js.org/docs/guides/communication.html#referencing-services

When JSON serialized, the state.children object is a mapping of service IDs (keys) to objects containing meta data about that service

[msurdi]

Thanks a lot for your explanations, this has been very useful to me💯

[msurdi]

So I just followed all these recommendations and the code looks a lot better to me now. Thanks!