Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when you import from code it create a lot of ghost machines #214

Closed
AlonGvili opened this issue Jan 15, 2024 · 2 comments
Closed

when you import from code it create a lot of ghost machines #214

AlonGvili opened this issue Jan 15, 2024 · 2 comments
Assignees

Comments

@AlonGvili
Copy link

@Flea.market.project._.@api._.Stately.webm

Studio version: 0.111.0

@kevinmaes
Copy link

Hi @AlonGvili Thanks for this feedback and for the repro video! By any chance, does the machine you're exporting and importing contain several invoked actors? If you can share the machine that would be helpful but we can also work to reproduce this on our end in the meantime and come up with a more expected solution so that it doesn't add those "ghost" machines which I understand to be rather unexpected.

@kevinmaes kevinmaes self-assigned this Jan 16, 2024
@kevinmaes
Copy link

@AlonGvili For XState v5 we now export actors with fromPromise() or for XState v4 we export an async function that also returns a promise. No more "ghost" machines will be created when importing machines with invoked actors.

However, we'll continue to think about ways to actually import invoked actor machines so that their association will be clearer in the future. Thanks again for your feedback on this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants