Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Link to Full Resolution Image #777

Open
AdultSun opened this issue Mar 11, 2024 · 0 comments
Open

[Feature] Link to Full Resolution Image #777

AdultSun opened this issue Mar 11, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@AdultSun
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Previously, resized images were listed incorrectly in the edit queue, using their resized resolution instead of the full resolution. This bug was described in issue #662 and has since been resolved.

However, full resolution images are still only easily accessible through peolic's userscript. In the vanilla presentation of Stash-Box, only the resized image is displayed throughout the UI, including in the edit queue when the full resolution is listed. This makes it more difficult for contributors to restore a full-size image when it has been overwritten by the smaller resized image, an unfortunately common occurence.

Describe the solution you'd like
Incorporating many of the features of peolic's userscript would go a long way. I went into more detail with various screenshots in #662 describing how it works. The visual language used by peolic's userscript is a bit counter-intuitive and inconsistent for me though. Sometimes the resolution labels are hyperlinks, sometimes they aren't. When an image has been resized an (R) hyperlink will appear throughout the UI, but clicking it opens the full-sized image and not the "resized" image that the "R" references. Also the resolution label will only hyperlink to an image with that listed resolution when it hasn't been resized. Instead, clicking the hyperlink on a label of 1920 x 1080 will actually open the image resized down to 1280 x 720 instead with the full-sized image is hidden behind the (R) hyperlink. These shortcuts and inconsistencies aren't a huge deal when only a small number of power users have the userscript, but they will need to be addressed if that functionality is added to stash-box itself. In order for new and less active users to understand what's going on, we also may have to spell it out more explicitly with labels like Resized from <res> or Original size is <res>.

Essentially, the remaining functionality exclusive to the userscript includes the following:

  1. Turn the resolution labels in the edit queue into hyperlinks
    • Clicking 1920 x 1080 should open the full image in a new tab. Right now, you have to right-click the image and it only opens the resized 1280 x 720 image instead.
  2. Add a link to the full-size image in the scene details pages
    • For me, the (R) hyperlink from the userscript is counterintuitive since it doesn't link to the "resized" image, so I'd change that to something else. Maybe an (F) for "full" or an (O) for "original"? A separate hyperlink for the smaller resized image is not needed since it can be easily opened with a right-click on the displayed image.
  3. Adds resolution labels and hyperlinks to the performer image carousel
    • Again, the userscript's labels feel counter-intuitive here for me. The resolution label here is not a hyperlink, which is fine if we're adding a separate hyperlink for the full-size copy of the image. However, that wouldn't be needed if the resolution label itself was a hyperlink. Also a separate hyperlink for the smaller resized image is still not necessary here since we can easily right-click the displayed image.
  4. Adds resolution labels and hyperlinks to the "Images" tab of the edit forms
    • The same visual language established in the earlier locations should be mirrored here as well. Resolution labels should be listed for each image and if they're also hyperlinks to open in a new tab, then the linked image should be the full-size image that matches the resolution label.

Describe alternatives you've considered
It's possible that more comprehensive links and labels to make stash-box's image resizing more transparent would be too confusing to the average user. If that's the case, then maybe some or all of these additions could be hidden from users without the EDIT role, or we could leave it exclusive to power users by reserving that functionality for the userscript. However, the current situation has been confusing and sometimes frustrating for many contributors who are unaware of stash-box's image resizing feature.

@AdultSun AdultSun added the enhancement New feature or request label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant