Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update starknet_simulateTransactions spec for simulation flags #185

Open
greged93 opened this issue Dec 13, 2023 · 0 comments
Open

Comments

@greged93
Copy link

I suggest the following update to the starknet_simulateTransactions: instead of passing the flags for the starknet_simulateTransactions params as an array of SIMULATION_FLAG, change to:

{
    "type": "object",
    "properties": {
        "skip_validate": {
            "title": "Skip validation flag",
            "type": "boolean",
            "description": "Flag that indicates if the validation should be skipped for the transaction. Default value is `false`"
        },
        "skip_fee_charge": {
            "title": "Skip fee charge flag",
            "type": "boolean",
            "description": "Flag that indicates if the fee charging should be skipped for the transaction. Default value is `false`"
        },
    "required": [
        "skip_validate",
        "skip_fee_charge",
    ]
}

This would allow to pass a skip_validate and skip_fee_charge flag for each transaction that is passed to the endpoint in the array, giving more control to the user over which transactions should skip validation or fee charge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant