Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(fee): use valid resource bounds in blockifier #537

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

nimrod-starkware
Copy link
Contributor

@nimrod-starkware nimrod-starkware commented Aug 20, 2024

This change is Reviewable

@nimrod-starkware nimrod-starkware marked this pull request as ready for review August 20, 2024 13:44
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/use_in_blockifier branch from f48e321 to f2eea66 Compare August 21, 2024 06:38
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/use_in_blockifier branch from f2eea66 to f672171 Compare August 21, 2024 06:42
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/use_in_blockifier branch from f672171 to 7f86b3c Compare August 21, 2024 06:47
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/use_in_blockifier branch from 7f86b3c to d2705a9 Compare August 21, 2024 07:44
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/use_in_blockifier branch from d2705a9 to 733e6d7 Compare August 21, 2024 08:32
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/use_in_blockifier branch from 733e6d7 to 067e9e9 Compare August 21, 2024 08:40
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/use_in_blockifier branch from 067e9e9 to c437bd5 Compare August 21, 2024 08:55
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/use_in_blockifier branch from c437bd5 to 50e633b Compare August 21, 2024 11:28
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)

@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/use_in_blockifier branch from 9cc6dd4 to c084459 Compare September 3, 2024 13:51
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/use_in_blockifier branch from c084459 to 3d3c960 Compare September 3, 2024 15:17
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/use_in_blockifier branch from 3d3c960 to 7fbf370 Compare September 4, 2024 06:39
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/use_in_blockifier branch from 7fbf370 to 391f48d Compare September 4, 2024 07:04
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/use_in_blockifier branch from 391f48d to 05c8794 Compare September 4, 2024 11:07
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/use_in_blockifier branch from 05c8794 to 1ef14b7 Compare September 4, 2024 11:09
Copy link
Contributor Author

nimrod-starkware commented Sep 4, 2024

Merge activity

@nimrod-starkware nimrod-starkware changed the base branch from nimrod/resources_enum/tx_args to graphite-base/537 September 4, 2024 13:02
@nimrod-starkware nimrod-starkware changed the base branch from graphite-base/537 to main September 4, 2024 13:02
@nimrod-starkware nimrod-starkware force-pushed the nimrod/resources_enum/use_in_blockifier branch from 1ef14b7 to d0d3003 Compare September 4, 2024 13:03
Copy link
Contributor Author

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)

@nimrod-starkware nimrod-starkware merged commit 2dcefb9 into main Sep 4, 2024
16 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants