Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: align blockifier main #12

Closed
wants to merge 5 commits into from

Conversation

dorimedini-starkware
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware commented Jul 11, 2024

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information


This change is Reviewable

Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 105 files reviewed, 2 unresolved discussions (waiting on @alon-dotan-starkware)


crates/papyrus_monitoring_gateway/src/lib.rs line 316 at r2 (raw file):

    match prometheus_handle {
        Some(handle) => {
            Collector::new(PROCESS_METRICS_PREFIX).collect();

clippy error required this change

Code quote:

 Collector::new(PROCESS_METRICS_PREFIX).collect();

scripts/clippy.sh line 3 at r2 (raw file):

#!/bin/bash

cargo clippy "$@" --all-targets --all-features -- -Aclippy::blocks_in_conditions

@dan-starkware many papyrus errors for this lint; can you assign someone to fix them and remove this -A option?

Code quote:

 -- -Aclippy::blocks_in_conditions

@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants