Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests-integration): bump nonces in state #1064

Open
wants to merge 1 commit into
base: gilad/refactor-state-reader
Choose a base branch
from

Conversation

giladchase
Copy link
Contributor

@giladchase giladchase commented Sep 27, 2024

When injecting a deployed account into the state, its nonce must be > 0, since this injection simulates a deploy-account being added to the state, which must therefore bump the nonce to 1.


This change is Reviewable

When injecting a deployed account into the state, its nonce must be > 0,
since this injection simulates a deploy-account being added to the
state, which must therefore bump the nonce to 1.
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Please upload report for BASE (gilad/refactor-state-reader@2afbd7e). Learn more about missing BASE report.

Files with missing lines Patch % Lines
crates/tests-integration/src/state_reader.rs 0.00% 8 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                      @@
##             gilad/refactor-state-reader   #1064   +/-   ##
=============================================================
  Coverage                               ?   0.61%           
=============================================================
  Files                                  ?     208           
  Lines                                  ?   21627           
  Branches                               ?   21627           
=============================================================
  Hits                                   ?     134           
  Misses                                 ?   21482           
  Partials                               ?      11           
Flag Coverage Δ
0.61% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @giladchase and @Yael-Starkware)


crates/tests-integration/src/state_reader.rs line 324 at r1 (raw file):

        self.set_contracts(accounts_defined_in_the_test).declare().deploy().fund();

        // Set nonces as 1 in the state so that invokes can pass validation.

Suggestion:

that subsequent invokes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants