Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: calldata utils improvements & tests #1221

Merged
merged 31 commits into from
Sep 11, 2024
Merged

chore: calldata utils improvements & tests #1221

merged 31 commits into from
Sep 11, 2024

Conversation

lukasaric
Copy link
Contributor

@lukasaric lukasaric commented Sep 6, 2024 •
edited
Loading

Motivation and Resolution

Resolves #1220

Test coverage within ./src/utils/calldata:

  • - cairo
  • - validate
  • - tuple
  • - byteArray
  • - enum foler ( CairoResult, CairoOption & CairoCustomEnum)
  • - parser folder
  • - formatter

Added ABI factories within mocks

RPC version (if applicable)

...

Usage related changes

  • Change 1.
  • ...

Development related changes

  • Change 1.
  • ...

Checklist:

  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Linked the issues which this PR resolves
  • Documented the changes in code (API docs will be generated automatically)
  • Updated the tests
  • All tests are passing

@lukasaric lukasaric marked this pull request as draft September 6, 2024 06:37
@ivpavici ivpavici mentioned this pull request Sep 6, 2024
Merged
@ivpavici ivpavici marked this pull request as ready for review September 6, 2024 12:27
@ivpavici ivpavici marked this pull request as draft September 6, 2024 12:32
@lukasaric
Merge branch 'develop' into chore/calldata-utils
d20e58f 
# Conflicts:
#	src/utils/calldata/formatter.ts
#	src/utils/calldata/tuple.ts
@lukasaric
chore: add tuple validation & and more array per type cases
beac21e
@lukasaric
chore: add struct validation tests & improve Literal const
87994b8
@lukasaric
chore: cover enums validation tests in detail
54c1cec
@lukasaric
chore: decouple eth address constant from literal
9e89ace
@lukasaric
chore: add non zero type validation
f95adc0
@lukasaric
chore: add missing enum & struct array cases
e03b116
@lukasaric
chore: add byte array util tests
cd9815a
@lukasaric
chore: add cairo util tests partially
b07c6e8
@lukasaric
chore: improve cairo test coverage
84a4b32
@lukasaric
chore: summarize cairo tests
ef39d15
@lukasaric
chore: add formatter tests & fix JS docs in it
5e29a19
@lukasaric
chore: improve obj keys naming
8615c2a
@lukasaric
chore: change obj keys nomenclature in js docs
5a48641
@lukasaric
chore: add tests for 2.0.0 parser
4d1cf4e
@lukasaric
chore: add parser 1 tests
9d86594
@lukasaric
chore: add parser index tests
9fff468
@lukasaric lukasaric marked this pull request as ready for review September 9, 2024 15:20
ivpavici
ivpavici reviewed Sep 10, 2024
View reviewed changes
__tests__/utils/calldata/parser/parser.test.ts Outdated Show resolved Hide resolved
__tests__/utils/calldata/validate.test.ts Outdated Show resolved Hide resolved
__tests__/utils/calldata/validate.test.ts Show resolved Hide resolved
__tests__/utils/calldata/validate.test.ts Outdated Show resolved Hide resolved
__tests__/utils/calldata/validate.test.ts Outdated Show resolved Hide resolved
src/utils/calldata/parser/index.ts Show resolved Hide resolved
src/utils/calldata/validate.ts Outdated Show resolved Hide resolved
tabaktoni
tabaktoni requested changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@tabaktoni tabaktoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM, just move abi.ts back to test, as mocks are non-refatoring element of tests.

__mocks__/factories/abi.ts Outdated Show resolved Hide resolved
src/utils/calldata/enum/CairoCustomEnum.ts Show resolved Hide resolved
@tabaktoni tabaktoni self-requested a review September 11, 2024 13:40
@ivpavici ivpavici merged commit b4198bd into starknet-io:develop Sep 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippeR26 PhilippeR26 PhilippeR26 left review comments

@tabaktoni tabaktoni tabaktoni approved these changes

@ivpavici ivpavici ivpavici approved these changes

@penovicp penovicp penovicp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

utils calldata tests coverage
5 participants
@lukasaric @tabaktoni @ivpavici @penovicp @PhilippeR26